Growthcraft Bamboo Forest support
Sunconure11 opened this issue ยท 23 comments
Growthcraft is being continued, so, would it be possible to add support for its bamboo forest?
Nice, thanks for the suggestion. Should be relatively easy to add support.
Been looking into this one, and I think I'd like Growthcraft to be the first mod to use the API for biome support, assuming the Growthcraft devs are up for it (and assuming it's not going to require a massive re-write of RTG, which I don't think it will). They have a well-documented contribution workflow, and since it's only one biome, it seems like a pretty ideal candidate.
I'll see if I can get this into 0.6, although if it means a massive refactoring, it might have to wait until 0.7
You're probably right... from my initial investigations, it will hopefully just involve exposing a few classes to the API and adding a couple Forge events.
@IceDragon200 I'm pleased to hear that you're keen to add support. Sadly, the biome support system hasn't been added to our API yet - it's something I'm working on for our 0.6 release. As soon as it's ready though, I'll be sure to write up some documentation.
@whichonespink44 Hello, a (lead) Growthcraft Developer here, if you don't mind, giving me a quick guide on how to add support would appreciated, I'd add it rather promptly
@Sunconure11 @IceDragon200 Quick update... the biome support portion of the API isn't going to be finished anytime soon, so... I'll be adding inherent support for GrowthCraft's Bamboo Forest in RTG 0.7.0, tentatively scheduled to be released on 21st Feb. If you want, I can post a snapshot build here before it's released so you guys can suggest tweaks.
@whichonespink44 If its aesthetics, talk with @Sunconure11, @Ar97x or @PitchBright, I'm only fussy about code
I would say something similar to what is in now, but, maybe add bits of podzol and some rocks here and there.
@IceDragon200 Possible bug, maybe see if you can fix this in a dev build
@whichonespink44 @Sunconure11 It's not a bug, its a feature!
Looks like the code was using some old method that was removed in 1.7 (don't forget this was ported from 1.6 previously), I've fixed it in the latest dev build :)
Tricksy methodses!
That's awesome - looking forward to the next release :)
GrowthcraftCE/Growthcraft-1.7#200
Use the latest dev build, growthcraft fixed the bamboo forests.
@Sunconure11 @IceDragon200 I know it's only a preview build, but... just an FYI... the latest preview build (95dc5fc) crashes on startup: http://pastebin.com/dA1u6T3h
Adding Forestry prevents the crash.
EDIT: Bamboo Forest is looking good! ๐
Added in 5f00d4b
@IceDragon200 Latest development snapshots can be found here:
https://github.com/Team-RTG/Realistic-Terrain-Generation/wiki/Development-Snapshots
@whichonespink44 Thanks :D
@whichonespink44 Fak I knew I missed something, thanks for pointing that out, glad it works.
Oh, do you have dev builds I could test with?