[1.9.4] Crash with BoP
whichonespink44 opened this issue · 15 comments
From @JCMais on June 9, 2016 0:58
Affected Mod Versions
- Forge: 12.17.0.1954
- RTG: RTG-1.9.4-2.0.0-alpha.5
- BoP: BiomesOPlenty-1.9.4-4.1.0.2025-universal
Issue Description:
Crash during initial world loading.
Crash-log: https://gist.github.com/JCMais/ede876013bb190dfbc15f500a29abb60
Steps to reproduce the issue: (If it's easily reproducible.)
Enable B:"Use BOP biome layout if avaliable"=true in the configuration file and try to generate a new world.
biome is null here: https://github.com/Team-RTG/1.9-Realistic-Terrain-Generation/blob/dev/src/main/java/teamrtg/rtg/core/world/ChunkProviderRTG.java#L662
Edit: After more investigation, the whole biomes array is null, also, the biomeGenerators array from the RealisticBiomeGenerator class is missing all BoP biomes, see below:
This is an issue, because the biomes array is populated with calls to RealisticBiomeGenerator.getRealistic
Copied from original issue: Team-RTG/1.9-Realistic-Terrain-Generation#126
From @Zeno410 on June 10, 2016 13:41
I think this can happen if a biome is assigned to 255.
From @Ezoteric on June 10, 2016 14:49
yeah, bugger we cant enter the world for a dump... which we cant do without nei ? :P
From @srs-bsns on June 10, 2016 17:44
yeah, bugger we cant enter the world for a dump... which we cant do without nei ? :P
There is an alpha version of Mantle released for 1.9.4 which can be used to dump biome IDs with the config setting B:"Dump BIOME ID's in log"=true
From @Ezoteric on June 10, 2016 21:0
i do have mantle but i dont see a config :p
i may check tell me :)
From @srs-bsns on June 10, 2016 21:8
Hrm.. you mean there's no settings in /config/SlimeKnights/Mantle.cfg?
From @Ezoteric on June 10, 2016 21:10
i dont have a slimeknight config .... weird maybe older version
From @srs-bsns on June 10, 2016 21:34
Yeah, after looking at the source, it appears they removed the dump features, all the way back in 1.8.9. Oh well.
From @Ezoteric on June 10, 2016 21:38
np :) we still got tellme ;)
From @JCMais on June 11, 2016 3:31
Here is the biome dump: https://gist.github.com/JCMais/7385b1ac1763c49c1a833e6834d5d2f5
No biome with id 255.
From @topisani on June 20, 2016 0:15
the biomeGenerators array looks normal to me on that screenshot. What should be wrong with it?
From @JCMais on June 20, 2016 5:34
@topisani I don't recall exactly where, but it tries to get the biome generator for a BOP biome from that array, but as it's not in there, Null is returned, which causes the original issue.
To be more exact:
here is where the biomes array (passed to the getNewerNoise) is populated, with calls to https://github.com/Team-RTG/1.9-Realistic-Terrain-Generation/blob/dd61c955083ec06a70f8d08cf57a6162fccea476/src/main/java/teamrtg/rtg/api/world/biome/RTGBiome.java#L149 which in turns calls https://github.com/Team-RTG/1.9-Realistic-Terrain-Generation/blob/dd61c955083ec06a70f8d08cf57a6162fccea476/src/main/java/teamrtg/rtg/api/world/gen/RealisticBiomeGenerator.java#L49
fixed in #839
this apears to be due to the BOP biomes not being added to RealisticBiomeGenerator.biomeGenerators for one reason or another, if one (@whichonespink44) were to take a look at it, they should probably follow the trail that starts here