[1.7.10][RTG-1.0.1] Crashes on creating non-RTG worlds
OneEyeMaker opened this issue ยท 8 comments
Hello.
I found simple and strange bug. If I understand correctly, RTG tries to properly select material for villages in desert biomes.
But there is bug, that crashes the world, if world type is not Realistic. (I just tried to create simple superflat world).
Also, as I see in code, RTG doesn't handle villages in desert biomes if UBC is installed. (UBC has config option to replace all stone stuff in villages). And I often see (UBfied) cobblestone villages in desert.
Please, fix these problems (check type of world and check UBC stones in villages). Both these ones are in this method.
P. S. Sorry for my English, I'm from Russia.
Yeah, im getting the same crash report, tried to make myself a superflat world for bug testing -> boom crash straight away.
I'm unable to reproduce this crash.
Using only RTG 1.0.1 and a few utility mods, I can load up a Superflat world just fine.
In fact, RTG has code that unregisters its event handlers if not in an RTG world:
That's basically saying "hey, if I'm not in an RTG world, then I'm not gonna interfere with anything" - so the only thing I can think of is that another mod is interfering somehow. If I had to guess, I'd say that Tinkers Construct and/or AgriCraft is using ASM to hijack our event handlers and somehow re-registering them?
@Team-RTG/rtg-writers Any other ideas?
We need to test that code linked above to make sure it's getting fired when the world loads.
As I mentioned earlier in chat, I was able to reproduce this crash with RTG and UBC in a superflat world (desert preset).
I'm not sure the event manager is getting properly unregistered with the current design.
I'm been messing about with a fix that seems to work just fine, but I've been getting side-tracked, so I haven't been able to do thorough testing.
I should have a fix ready tomorrow sometime.
Fixed in: #820
I tested version 1.1.0-snapshot-1.
Village generation in non-RTG worlds doesn't cause crash. Thank you for it.
But, one problem isn't fixed: RTG replaces only vanilla stone/cobblestone stuff in villages.
On my modpack I've also UBC installed. And, if I understand correctly, UBC runs before RTG.
Result of that:
http://imgur.com/5RVWmjO
I guess, you should just add another checks (is UBC loaded and is block from UBC).
RTG no longer replaces village blocks, so that's probably an issue with UBC and should be reported on its forum thread.
To confirm, try removing UBC and loading a new world with the same seed and flying to the coords in the screenshot you posted. If it looks like a normal desert village, then it's not a bug with RTG.
I'm closing this as the original bug has been fixed, but please report back here with any updates on the village bug. If it turns out to be a problem with RTG, we'll create a separate issue for it.