1.12.1 port
xbony2 opened this issue ยท 13 comments
Having one issue though - for some reason it fails when I load the mod using the Twitch launcher in a modpack.
net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from Realistic Torches (realistictorches)
Caused by: java.lang.NoSuchMethodError: com.chaosthedude.realistictorches.blocks.BlockTorchUnlit.setUnlocalizedName(Ljava/lang/String;)Lnet/minecraft/block/Block;
Not sure why yet. If anyone happens to know how to resolve this (I have already updated the mappings, made sure I am building with the same forge version as the twitch client launches with, etc.) I'd be interested. Google isn't quite helping as much as I'd like and I'm still pretty new to building mods for deployment.
Yeah. Some part of your code is calling BlockTorchUnlit#setUnlocalizedName
, but setUnlocalizedName
should have reobfuscated to func_somethingobfuscated
when you did ./gradlew build
.
Ok, fixed that. Now there's a mod interaction issue I am tracking down. Almost there! Funny how all this works in the isolated environment...
net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from Realistic Torches (realistictorches)
Caused by: java.lang.NullPointerException
at codechicken.enderstorage.block.BlockEnderStorage.getLightValue(BlockEnderStorage.java:221)
at com.chaosthedude.realistictorches.handler.LightSourceHandler.registerLightSources(LightSourceHandler.java:26)
So Block.getLightValue(IBlockState) is deprecated in favor of one which takes a world and position. During setup, RT is trying to find blocks which passively emit light, while this EnderStorage block only emits light if it is attached to a tile entity, and to figure that out it needs a world and a position. I can fake a position, but there's no world. I wonder what the correct way to fix this is...
I just merged the PR, made a few changes, and submitted version 1.12.2-2.1.1 on CurseForge. Thanks for the help in updating, @ChronosWS , and sorry for the huge delay in actually getting a 1.12 release out.