[1.12.2] RebornStorage version 3.1.0.58 not converting old patterns when upgrading from version 3.0.6.43

Question

[1.12.2] RebornStorage version 3.1.0.58 not converting old patterns when upgrading from version 3.0.6.43

escman1999 opened this issue 6 years ago · 6 comments

escman1999 commented 6 years ago

there's supposed to be conversion code; but it seems that things aren't working as intended; upon loading a world that previously used rebornstorage version 3.0.6.43, all old patterns that were in the rebornstorage multiblock are invalid

escman1999 · Answer 1 · 2018-07-06T12:48:42.000Z

the patterns that aren't invalid, are ones i just created

raoulvdberge · Answer 2 · 2018-07-06T13:29:11.000Z

I still have to make that conversion code available in the API.

escman1999 · Answer 3 · 2018-07-06T13:33:58.000Z

i know; but one of the rebornstorage devs told me to open an issue; so i did

raoulvdberge · Answer 4 · 2018-07-06T21:32:28.000Z

Fixed by refinedmods/refinedstorage@7fc99b5

Call IOneSixMigrationHelper#migratePatternInventory when reading the crafting node from NBT.

If it returns true, you have to mark the inventory as dirty.

modmuss50 · Answer 5 · 2018-07-07T07:40:45.000Z

Sounds good, I’ll get around to adding when I get a chance.

modmuss50 · Answer 6 · 2018-07-16T09:48:18.000Z

ok, should be fixed now, let me know of any more issues

Share to