Multiple rebuildPatterns running

Question

Multiple rebuildPatterns running

Sir-Will opened this issue 6 years ago · 7 comments

Sir-Will commented 6 years ago

I added a debug message here: https://github.com/TechReborn/RebornStorage/blob/1.12/src/main/java/me/modmuss50/rebornstorage/tiles/CraftingNode.java#L127 and noticed that the rebuildPatterns is being run multiple times for the same system.
Shouldn't this only run once per chunk load and system change?

[16:14:44] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=244, y=89, z=2308}
[16:14:44] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=242, y=89, z=2309}
[16:14:44] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=242, y=89, z=2308}
[16:14:44] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=243, y=89, z=2306}
[16:14:44] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=243, y=89, z=2307}
[16:14:45] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=244, y=89, z=2307}
[16:14:45] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=242, y=89, z=2307}
[16:14:45] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=244, y=89, z=2306}
[16:14:45] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=245, y=89, z=2306}
[16:14:45] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=243, y=89, z=2308}
[16:14:45] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=245, y=89, z=2309}
[16:14:45] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=244, y=89, z=2309}
[16:14:45] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=245, y=89, z=2307}
[16:14:45] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=243, y=89, z=2309}
[16:14:45] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=242, y=89, z=2306}
[16:14:46] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=245, y=89, z=2308}
[16:14:46] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=-1295, y=81, z=1793}
[16:14:46] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=-1295, y=82, z=1793}
[16:14:46] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=-1295, y=80, z=1793}
[16:14:46] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=-1296, y=80, z=1793}
[16:14:46] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=-1296, y=81, z=1793}
[16:14:46] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=-1297, y=82, z=1793}
[16:14:46] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=-1297, y=80, z=1793}
[16:14:46] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=-1297, y=81, z=1793}
[16:14:46] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=-1296, y=82, z=1793}
[16:15:18] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=242, y=89, z=2308}
[16:15:18] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=242, y=89, z=2309}
[16:15:18] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=244, y=89, z=2307}
[16:15:18] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=242, y=89, z=2307}
[16:15:18] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=244, y=89, z=2308}
[16:15:18] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=243, y=89, z=2308}
[16:15:19] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=245, y=89, z=2307}
[16:15:19] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=242, y=89, z=2306}
[16:15:19] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=244, y=89, z=2309}
[16:15:19] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=245, y=89, z=2306}
[16:15:19] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=245, y=89, z=2308}
[16:15:19] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=245, y=89, z=2309}
[16:15:19] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=243, y=89, z=2306}
[16:15:19] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=243, y=89, z=2309}
[16:15:19] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=244, y=89, z=2306}
[16:15:19] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=243, y=89, z=2307}
[16:15:51] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=243, y=89, z=2307}
[16:15:52] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=244, y=89, z=2307}
[16:15:52] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=243, y=89, z=2309}
[16:15:52] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=245, y=89, z=2308}
[16:15:52] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=244, y=89, z=2306}
[16:15:52] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=244, y=89, z=2308}
[16:15:52] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=242, y=89, z=2308}
[16:15:52] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=245, y=89, z=2306}
[16:15:52] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=243, y=89, z=2308}
[16:15:52] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=245, y=89, z=2309}
[16:15:53] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=242, y=89, z=2309}
[16:15:53] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=245, y=89, z=2307}
[16:15:53] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=242, y=89, z=2306}
[16:15:53] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=242, y=89, z=2307}
[16:15:53] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=244, y=89, z=2309}
[16:15:53] [Server thread/INFO]: [STDOUT]: [me.modmuss50.rebornstorage.tiles.CraftingNode:rebuildPatterns:-1]: BlockPos{x=243, y=89, z=2306}

modmuss50 · Answer 1 · 2018-11-26T22:31:00.000Z

Im not sure how I can optimise this any more, does anyone have any suggestions?

Sir-Will · Answer 2 · 2018-11-28T15:35:04.000Z

Might be related: refinedmods/refinedstorage#2106

drunkripper · Answer 3 · 2018-12-04T05:05:22.000Z

Refer to #137 for inspiration possibly on how to better optimize.

modmuss50 · Answer 4 · 2018-12-05T01:06:10.000Z

Fixed it 👍 should only run once per tick at MAX now.

modmuss50 · Answer 5 · 2018-11-11T15:19:09.000Z

In newer versions each block handles its own patterns so I believe this is intended behavior. There may be cases where it rebuilds when it doesnt need to. Are you trying to track down a performance issue?

Sir-Will · Answer 6 · 2018-11-11T15:21:36.000Z

Yes, there is also that issue that completely freezes the server if the controller doesn't get enough energy to stay online because it keeps running rebuildPatterns.

Sir-Will · Answer 7 · 2018-11-11T20:57:17.000Z

Sir-Will commented 6 years ago

Share to