Rechiseled

Rechiseled

Mods
32M Downloads

[Bug] Mod contains loot tables for blocks not present in version, causing severe log spam

cursedgerbil opened this issue ยท 2 comments

commented

Version Info

  • Minecraft, 1.16.5
  • Rechiseled, 1.1.6
  • Fusion, 1.1.1.

What mod loader are you using?: Forge

Description of the Bug

The 1.16.5 version of 1.1.6 causes a massive amount of console spam on launch related to loot table errors. On closer inspection, the mod contains loot tables for blocks that are not present in that version of the mod - such as loot tables for the cobbled deepslate blocks, even though Deepslate and those blocks are not present in 1.16. Because the loot tables contain blocks that do not exist, Forge throws an error for every single one, causing lots of log spam.

Manually deleting these loot tables from the .jar fixes the problem.

Steps to Reproduce

Download the versions listed and try launching the game.

I was originally having this issue in a custom modpack, but it persists upon removing all mods other than Rechiseled and it's requirements, even in a new instance of the game.

commented

As far as I can tell there's no loot table for cobbled deepslate in the 1.16 branch https://github.com/SuperMartijn642/Rechiseled/tree/forge-1.16/src/generated/resources/data/rechiseled/loot_tables/blocks

All the loot tables are generated through code and there are no deepslate blocks from Rechiseled in 1.16. https://github.com/SuperMartijn642/Rechiseled/blob/forge-1.16/src/main/java/com/supermartijn642/rechiseled/RechiseledBlocks.java
It can't even generate any loot tables referencing deepslate as that would just throw an error when trying to generate all the data files.

I am confused how any such file would even end up in a 1.16 jar.

commented

I'm also confused how it would end up there. It's not on the branch (I did check previously), but for whatever reason, if you download the latest 1.16 CurseForge version here and extract it, those loot tables are there - even though they shouldn't have been generated yet as the mod hasn't even been run. Is it possible this is just a flimsy upload?

If you can't reproduce this (which would be very strange), I'm happy to record a video of me downloading and opening the jar to demonstrate the issue.