Vanilla decoration feature does not work with Biomes o' plenty.
TitusArmillius opened this issue ยท 1 comments
The issue posted here Glitchfiend/BiomesOPlenty#880, from the perspective of the BOP's dev's, specifically Adubbz, is that it is not their responsibility for this incompatibility, this being expressed in his response:
The only thing I can think he could be referring to is the following
https://github.com/Glitchfiend/BiomesOPlenty/blob/BOP-1.11.x-6.0.x/src/main/java/biomesoplenty/common/handler/decoration/DecorateBiomeEventHandler.java#L46
GitHub
Glitchfiend/BiomesOPlenty
BiomesOPlenty - Minecraft mod that adds over 50 new biomes to the overworld and Nether.
Which would be rather naive, because a quick look at the bottom of the file would show that that is no longer being used
https://github.com/Glitchfiend/BiomesOPlenty/blob/BOP-1.11.x-6.0.x/src/main/java/biomesoplenty/common/handler/decoration/DecorateBiomeEventHandler.java#L79-L104
GitHub
Glitchfiend/BiomesOPlenty
BiomesOPlenty - Minecraft mod that adds over 50 new biomes to the overworld and Nether.
His proposal relies on a pull request which hasn't been merged, and implementing a custom event really achieves nothing, since he can still utilise Forge's existing events whilst obtaining the amountPerChunk values himself
I've looked up how BoP currently handles decoration, and it seems to cancel the vanilla decoration event and insert their own.
This isn't reflective of our code in the slightest, so I'm not sure where he was looking...
We don't add any custom events.```
If he wants to discuss the issue I'd rather talk to him im person (i.e. why doesn't he just reply on GH? It's his repo). It appears like either I don't understand his codebase or he doesn't understand the issue. Either way it's not something I can fix from my side, so I'm closing this issue.