[1.3.1] Village Structures are cut off at chunk +8
miuirussia opened this issue ยท 26 comments
Maybe because bc9c03b working not as expected
I'm seeing this, too. But more importantly (I'm currently testing) I think structures outside of villages are not spawning at all.
Yep, confirmed. I just backed down to version 1.3.0 and structures generate normally.
I'm seeing structures generate outside of villages, but not many. I'm definitely seeing the brokeness in villages, seems to happen more to the structures I've added to the /structures/active folder.
Thanks for the great mod :)
@miuirussia I did a custom build with that commit reverted and the issue has vanished, so that commit is indeed the problem here.
I don't think @Ivorforce would like it if I redistributed the binary, but I will gist the patch I used.
Apply the patch with git apply --reverse fix-rc-issue-197.patch
This might be related as its probably caused by the same underlying problem: I'm currently playing around with a custom modpack that uses the latest Biome Bundle + OpenTerrainGenerator and I tested the last 3 RC-versions in combination with it (1.2.10, 1.3, 1.3.1) and villages were totally messed up. Most of the RC-structures only generated partially and even some vanilla-structures were broken. The same happened for a lot of structures outside of villages. Stuff like that huge mayan-style pyramid only generated half.
structures inside of villages seem to break at chunk line +8
I'm also getting alot of these lines: [13:22:03] [Server thread/TRACE] [reccomplex/]: StoneMazePath canceled generation at Optional[BlockPos{x=-582, y=14, z=-665}] (0) (unknown reason) with no out of village generation.
Here's a partial of my latest log https://pastebin.com/ZywPtjpN
If you switch to branch 1.10 and cherry pick the commits, yes - though i will do that soon myself if nobody here is on 1.11 anyway.
Didn't mean to close automatically, but I did find a big issue.
Here's a patched jar:
RecurrentComplex-1.3.1.jar.zip
Let me know if this one works. Otherwise I'll reopen this issue.
Here's a 1.10 build then:
Did some quick tests as I don't have much time: looked fine on a 1.10.2 Testworld with BoP-terraingen but was still broken on a BiomeBundle/OTG-world. Unfortunatly I don't have time to do more tests right now but will do some additional tests later today.
Will test this out on 1.11.2, thanks Ivorforce
edit: Update, seems to be working fine on 1.11.2. Thanks
Tried out your latest fix, RecurrentComplex-1.3.1.1-1.10.jar.zip, but I'm still seeing the same brokeness in villages.
That looks like something different entirely. Kind of like a ruins transformer, actually - with the gravity option enabled.
Can you make sure the only buildings affected are from ReC? (#whatisthis). If so, please open this up as a new issue since it's unrelated.
Crash, when I enter to Nether
crash-2017-05-17_22.17.59-server.txt
Ok, #204
So, I did some tests with a very minimalistic pack based upon RecurrentComplex-1.3.1.1-1.10.jar (basically it only contained "Chunk-Pregenerator", "JourneyMap" and depending on the test Quark, BB+OTG, etc.
Here are the results:
- Biome Bundle / OTG: villages are totally broken
- Quark Realistic Terrain: villages generate "as expected"
- Alternate Terrain Generation: villages generate "as expected"
- Realistic Terrain Generation + Climate Control: villages generate "as expected"
Looks like OTG does "something" that messes up structure-generation in villages pretty badly.
For those that might still be having some generation problems, I've found there is a conflict between the CustomOreGen mod and the MUON mod. It seems to affect villages but not structures outside of villages.