Redstone Pen

Redstone Pen

7M Downloads

use fabric-api id in fmj

Poopooracoocoo opened this issue ยท 6 comments

commented

you currently use the outdated fabric id. fabric api still provides it for backwards compat but it can confuse users.

tested with https://modrinth.com/mod/redstonepen/version/1.11.41

  • you should remove the another-mod suggestion.
  • you should tighten the minecraft dependency to 1.21, 1.21.1. ~1.21 does not work because Minecraft does not follow SemVer.
commented

Hi, ty for the hint, I'll include a fix in the next iteration. Cheers,-

commented

Fixed in v1.11.42.

commented

Just a heads up that with https://modrinth.com/mod/redstonepen/version/1.11.42 the fabric-api id isn't used in the fmj

commented

Hi, ty for double checking. I think I have a problem understanding, the lines changes in the commit are in mod.json

"minecraft": "~1.21" -> "minecraft": ["1.21", "1.21.1"]

d78da0f#diff-882c6606823cf6c4e4114c1125850a04ed3180c48aef0e1467f1e4022b235db2L27-L34

Did you mean that 1.20 should not be listed anymore, but only 1.21.1? I can remove that from the Modrinth meta data manually for a quick fix if so. Cheers,-

commented

No, that's not what I meant. But thank you for addressing my other two points. I'm referring to this line: https://github.com/stfwi/redstonepen/blob/fabric-1.21.1/src/main/resources/fabric.mod.json#L29

fabric needs to be replaced with fabric-api. The issue is the ID used for the Fabric API dependency.

commented

Oky, got it fixed now locally, it's gonna be in the next fabric fix iteration, so it's now

"depends": {
    "fabricloader": ">=0.15.10",
    "fabric-api": "*",
    "minecraft": ["1.21", "1.21.1"],
    "java": ">=17"
  }

Ty again for the hint;;