Move abstract classes outside commands package

Question

MiranCZ opened this issue 2 years ago · 12 comments

MiranCZ commented 2 years ago

Title

MiranCZ · Answer 1 · 2023-02-19T20:08:51.000Z

Maybe someone just forgot to move PickBlockFeature and RayCastFeature outside the packages?

Matthias1590 · Answer 2 · 2023-02-19T20:09:59.000Z

I think it's fine to have them like this

Matthias1590 · Answer 3 · 2023-02-19T20:10:16.000Z

If this ends up not working we can move the abstract classes somewhere else

MiranCZ · Answer 4 · 2023-02-19T20:11:09.000Z

Why is it like this? CommandFeature is outside. And you have those two inside with other actual commands

Matthias1590 · Answer 5 · 2023-02-19T20:05:43.000Z

I don't see the issue?

Matthias1590 · Answer 6 · 2023-02-19T20:06:03.000Z

They should all be in 1 package, each command is represented by 1 class anyway

MiranCZ · Answer 7 · 2023-02-19T20:07:19.000Z

Yeah, but then you have the abstract classes mixing up with the commands

Matthias1590 · Answer 8 · 2023-02-19T20:24:37.000Z

CommandFeature isnt outside?

MiranCZ · Answer 9 · 2023-02-19T20:27:38.000Z

Oh, AbstractFeature

Matthias1590 · Answer 10 · 2023-02-19T21:34:24.000Z

Yes, that's outside of the commands and toggleable packages because it is neither, its the superclass of all commands

MiranCZ · Answer 11 · 2023-02-20T05:52:50.000Z

And CommandFeature isnt superclass of all commands?

Matthias1590 · Answer 12 · 2023-02-20T11:55:11.000Z

No, only of command features (not toggleable ones), which is why it's in the commands package