
WAILA Integration
Micky2506 opened this issue ยท 17 comments
Not sure how I failed this, but here is the branch with the WAILA stuff:
https://github.com/MCMicky2506/RefinedRelocation/tree/waila_integration
Can't seem to create a good pull request for it, due to Github not getting that the previous one wasn't actually merged.
Github doesn't want to recognize that the previous commits weren't actually committed. :(
That would seem like a good idea, as otherwise I can't seem to convince Github that I do need to commit all the files.
Lets keep the conversation here, I pushed some changes, but I'm not sure how to best show the stuffed items.
I was thinking something along the lines of:
Apple x 64, Sapling x 10, Iron Block x 128
, but that is kind of lengthy, plus makes it difficult to accommodate large amounts of items (Multiple lines, etc). Is there a way to show the item icon in WAILA?
The current functionality of showing stuffing needs work.
Either we can go with my idea, or we could try to stay with this. But we definitely need to merge these 3 lines into one:
Stuffed: Block of Iron
Stuffed: Block of Iron
Stuffed: Block of Iron
If not, perhaps we do need to create our own stuffed item display, like TE does.
In addition to that, I would switch the modules and stuffed items places, because modules should (I think) take precedence.
Yea, this is not final at all, I just added them so you could see how and that it worked ;P
I know, just suggesting things. Looked at the code, I think I understand how to access NBT data now, so I'm thinking about adding a few more WAILA integrations to various blocks such as the relocation controller, the buffer, etc.
We could change the itemstack that now shows the Relocator every second to a stuffed item!
Closing since we merged #142 ; Hopefullly that one works. If not, well...
That seems like an interesting idea, and is very supported by WAILA. (I like the idea)
The list of stuffed items could still contain the item names and amounts, but - we could make the currently shown item italic/bold. That should be fairly easy, I've seen a WAILA implementation do that on Github:
https://github.com/asiekierka/endernet/blob/ad2dea18deeea95c3cc124a28171453648d58f05/pl/asie/endernet/integration/WailaIntegration.java#L33
Working on this now.. quite the task.
When changing the item, WAILA shows the item's data for the header and footer, do we want that?
Almost finished with this functionality, seems to be quite nice. Will probably pull request very soon. I've changed the time between items to 5 seconds, but it's just a variable, so if you want it's easy enough to change it to a configuration option.
See #146 for Pull Request for Item Stack showing for stuffed items.