Refined Relocation

Refined Relocation

3M Downloads

Unsaved Selection Choice

NullCascade opened this issue · 6 comments

commented

Using Resonant Rise v3.0.2.0, which has Refined Relocation 1.0.6g.

It has a large selection of mods. When filtering a chest, the selections stop being recognized at a certain index.

For example: I can check ten mods at a time going down the list. After "Genetic Templates" any selection of mod fails to remain active after closing and reopening the window.

commented

Haven't been able to confirm. Is it a specific mod? Have you tried not selecting "Genetic Templates"?

commented

I think this may be due to ContainerFiltered using sendProgressBarUpdate to transmit filter settings rather than a packet. I believe the progress bar value gets sent as a byte, so it'd fail on large filter lists.

One fix would be to create a new packet that handles setting filter options (the current filter-related packet only supports toggling) and use that instead of sendProgressBarUpdate for updating clients with the filter settings.

commented

It is not a specific mod, but rather all mods after a certain point. I can draw a line below a mod, and all mods beyond that do not save. Were you trying to confirm it in a large pack, such as on a Resonant Rise 3 server?

commented

Ahhhhh. Yeah, that'd do it. Thanks!
On Dec 5, 2014 5:02 PM, "Ryan Liptak" [email protected] wrote:

I think this may be due to ContainerFiltered using sendProgressBarUpdate
https://github.com/Dynious/RefinedRelocation/blob/master/src/main/java/com/dynious/refinedrelocation/container/ContainerFiltered.java#L62
to transmit filter settings rather than a packet. I believe the progress
bar value gets sent as a byte, so it'd fail past 255 filters.

One fix would be to create a new packet that handles setting filter
options (the current filter-related packet
https://github.com/Dynious/RefinedRelocation/blob/master/src/main/java/com/dynious/refinedrelocation/network/packet/MessageFilterOption.java
only toggles the setting) and use that instead of sendProgressBarUpdate for
updating clients with the filter settings.


Reply to this email directly or view it on GitHub
#237 (comment)
.

commented

Alrighty, should be fixed. :)