Refined Relocation

Refined Relocation

3M Downloads

Problem with newer versions of Forge and FMP

Haggle1996 opened this issue ยท 7 comments

commented

https://gist.github.com/Haggle1996/b77066a71f727edd2766

Encountering a problem when adding FMP to an existing pack with RR in it. Forge barfs on loading the FMP version of the relocator in an existing save.

This is extremely easy to replicate. Create a new vanilla install with recent Forge and RR. Create a new world. Close Minecraft and add Forge Multipart. Now try to reload the world. You'll recieve the following error message in the log:

"There is a high probability that a mod has broken the
ID map and there is
NOTHING FML or Forge can do to recover this save."

If its not possible to fix this problem, could a config option be added instead that makes RR ignore the presence of FMP?

commented

@Dynious Possible solution: register the relocator even if FMP is loaded but instead of adding the recipe for that one, add a recipe that turns non-fmp relocators into fmp-relocators?

Even then it would require a name change and break existing worlds though, so it'd have to be something we do between a Minecraft version update.

Also related to #145 by the way.

commented

I built a one-off version of RR 1.0.8b with IS_FMP_LOADED set to false instead of the lookup. This seems to solve the problem without breaking maps created with my pack. This version is only distributed inside my AT Launcher modpack (and given an alternate name, so it doesn't collide). I believe this is in accordance with your LPGL license, but if there are any problems, please let me know and I'll come up with something else.

commented

Yea, there's not a lot we can do at this moment. It was a bad decision to do this the way I did, I didn't really think of people adding and removing FMP.

commented

6f25a79 adds the config option!

commented

Looks perfect. Thanks!

commented

That will work and is absolutely fine :) I could make this a config option, so you could force-disable FMP integration, if you would like that!

commented

Making a config option is preferable so I don't have to make a one-off every time RR updates -- but regardless, thanks for making an awesome mod and helping with the issue. :)