Refined Relocation

Refined Relocation

3M Downloads

Finish new filtering system basics

BlayTheNinth opened this issue ยท 8 comments

commented
  • Add left/top margin to text in multi-line textbox
  • Fix whole-word-deletion in multi-line textbox
  • Add vertical and horizontal scrolling to multi-line textbox
  • Allow separation by both comma and newline in User filter
  • Add icons for Creative, Preset and User filter
  • Add header to Creative and Preset filter
  • Make the top of the filtering UI look good again
  • Apply new system to Adv. Filtered GUI as well
  • Localization
  • Implement the new icons for the filters
  • Advanced Filtered Block Extender in GUI -> Adv. Filtered Block Extender (for the looks)
  • Turn Redstone Signal Transmission into the other style button
  • Add the grey background box around the side thingy in Adv. Filtered Block Extender again
  • Add icons to the buttons on empty filter page
  • Make things more API-friendly
  • Separate options tab (at the top?)
  • Icon for the options tab
  • Tab button is one pixel off to the left when inactive
  • "Remove Filter" button
  • Increase height of filter list graphic
  • Fix scrollbar not stopping to scroll
  • Add Icon for empty filter tab
  • Stop multiline textbox from going to start when pressing down at end
  • Add tooltip to delete button
  • Add tooltips to filter type buttons
  • Add help text to the big empty space on the filter settings tab
  • Flickering when toggling redstone status button
  • GUI goes to first tab when adding a filter (but only once, afterwards it works fine)
  • Hide delete button on empty filter tabs
  • Help button has no tooltip anymore on user filter
  • Remove survival inventory and Search tabs from Creative Filter
  • Remove redstone button from WBE
commented

I really like the new Filtering, it's a lot more clean and will be less confusing for the user. This interface will also be more easy for us to update, as the back-end is more sensible than it was :P

There are a few things that might need some improvement though:

  1. The filtering system should be more extensible. Preferably no integer ids. This will make it a lot more easy for us to add new filter types. Adding new filter types should preferably also be possible using the API. This was already done in the newFiltering branch.
  2. Move block dependent settings like redstone, the advanced options and whitelisting to a separate 'options' tab. This will make the filter interfaces even more clean.
  3. Maybe add a more descriptive explanation on how to use the interface. (Add filters by using a button, white/blacklisting can be set by pressing the button etc.)
commented

Alright, got all of my points and the ones that you mentioned done now.

Just this GUI is still ugly and I'm not sure what to put there to get rid of the insane emptiness:

ugly

Maybe make it more in a list style (one filter type per line) and have mini-descriptions of the filter next to the buttons?

commented

Looks awesome! To make mods that support the old system work with the new one, we only need to change back the names to the old ones. (No mod has used the IFilterGUI methods). We could deprecate them and make interfaces with the new names that just extend the old ones until 1.8 and then we move functionality to the new interfaces.

commented

Okay, I'll do that then!

commented

Tested it with Compact Drawers and Enhanced Inventories and it works perfectly fine now.

Anything else left to do before I can merge it into master?

commented

Nope! Let's do it :D

commented

2015-06-05_16 32 42

commented

@Dynious Have a look at it please and let me know when I can merge. I tested the conversion from old to new and it worked fine, so existing worlds will continue to work.

There were API changes though!