Refined Storage

Refined Storage

Mods
115M Downloads

TPS Loss with exporters using crafting upgrades

Closed this issue ยท 1 comments

commented

Describe the bug

While using exporters with a crafting upgrade, I experienced large TPS loss on the server. Things that were being autocrafted were singular items such as buckets being exported into tanks, or blaze rod blocks being exported into power generators.

It seems that the more that single small items are requested, the higher the TPS cost, to the point where 5 exporters ordering crafts at the same time would reduce TPS down to 10.

How can we reproduce this bug or crash?

  1. Place exporter on accepting block
  2. Crafting upgrade with item in question
  3. Autocraft setup for item
  4. Repeat until server loses TPS, usually around 5-10 exporters logging crafting requests at the same time.

What Minecraft version is this happening on?

Minecraft 1.21.1

What NeoForge or Fabric version is this happening on?

21.1.168

What Refined Storage version is this happening on?

2.0.0-beta2

Relevant log output

Dump from performance profiler -- 
Version: 1.21.1
Time span: 802 ms
Tick span: 1 ticks
// This is approximately 1.25 ticks per second. It should be 20 ticks per second

--- BEGIN PROFILE DUMP ---

[00] tick(1/1) - 99.94%/99.94%
[01] |   #getChunkCacheMiss 12/12
[01] |   #getChunk 201/201
[01] |   levels(1/1) - 99.90%/99.85%
[02] |   |   ServerLevel[world] minecraft:overworld(1/1) - 99.02%/98.87%
[03] |   |   |   tick(1/1) - 99.99%/98.86%
[04] |   |   |   |   #getChunkCacheMiss 19/19
[04] |   |   |   |   #getChunk 1461/1461
[04] |   |   |   |   blockEntities(1/1) - 96.80%/95.69%
[05] |   |   |   |   |   refinedstorage:exporter(23/23) - 98.61%/94.37%
[06] |   |   |   |   |   |   #getChunkCacheMiss 8/8
[06] |   |   |   |   |   |   #getChunk 669/669
[05] |   |   |   |   |   unspecified(1/1) - 0.56%/0.54%
[05] |   |   |   |   |   refinedstorage:cable(549/549) - 0.17%/0.17%
[06] |   |   |   |   |   |   #getChunkCacheMiss 105/105
[06] |   |   |   |   |   |   #getChunk 11337/11337
[05] |   |   |   |   |   cabletiers:ultra_disk_interface(1/1) - 0.08%/0.08%
[06] |   |   |   |   |   |   #getChunk 7265/7265
[05] |   |   |   |   |   enderio:conduit(387/387) - 0.07%/0.07%
[05] |   |   |   |   |   minecraft:mob_spawner(88/88) - 0.05%/0.05%
[06] |   |   |   |   |   |   #getEntities 2/2
[06] |   |   |   |   |   |   #getChunkCacheMiss 1/1
[06] |   |   |   |   |   |   #getChunk 147/147
[05] |   |   |   |   |   minecraft:hopper(17/17) - 0.04%/0.04%
[06] |   |   |   |   |   |   #getEntities 9/9
[06] |   |   |   |   |   |   #getChunkCacheMiss 2/2
[06] |   |   |   |   |   |   #getChunk 74/74
[05] |   |   |   |   |   cabletiers:elite_exporter(1/1) - 0.04%/0.03%
[06] |   |   |   |   |   |   #getChunkCacheMiss 1/1
[06] |   |   |   |   |   |   #getChunk 28/28
[05] |   |   |   |   |   refinedstorage:importer(31/31) - 0.03%/0.03%
[06] |   |   |   |   |   |   #getChunkCacheMiss 12/12
[06] |   |   |   |   |   |   #getChunk 807/807
[05] |   |   |   |   |   lootr:lootr_chest(192/192) - 0.02%/0.02%
[06] |   |   |   |   |   |   #getChunkCacheMiss 14/14
[06] |   |   |   |   |   |   #getChunk 20/20
commented

#987