Autocrafting with Industrial Foregoing Dissolution Chamber keeps voiding my stuff
Closed this issue · 3 comments
Describe the bug
In ATM10, I'm trying to autocraft an 'More Industrial Foregoing Addons' 'Addon: Efficiency Tier 3' with an autocrafter pointing at an 'Industrial Foregoing' 'Dissolution Chamber'. The pattern is a glass pane, the IF 'Pink Slime' fluid, and a bunch of other stuff:

However, instead of crafting the thing I want, the Dissolution Chamber crafts a pink slime item: Pink slime fluid plus a glass pane without the other stuff is already the receipe for the pink slime item, and it looks like (by chance?) the pink slime fluid and a glass pane get pushed into the dissolution chamber first, which makes it lock all the other slots, even though it would have accepted the other items in the recipe individually.
On another day, I've been able to do this craft just fine. However today, within a single session of the game (or server startup?), the craft consistently fails and I get the below log messages every single time.
I guess it's just a bad coincidence that a prefix of a permutation of the ingredients are already the ingredients of another full recipe. I think it's possible for me to work around this by locking slots on the Dissolution Chamber, but that seems like an unexpected limitation, and voiding ingredients is a really unfortunate failure mode. It took me a good while to understand why my crafts weren't happening and where my netherite was going.
How can we reproduce this bug or crash?
- Install ATM10 mod pack version 3.0 I guess
- Set up an Industrial Foregoing Dissolution Chamber and supply it with Forge Energy.
- Set up a Refined Storage network with an autocrafter with the above processing pattern pointed at the Dissolution Chamber.
- Provide the ingredients and request autocrafting the Addon: Efficiency Tier 3
- Get my unlucky RNG where the first ingredients that are inserted into the Dissolution Chamber are a complete Dissolution Chamber recipe on their own
I don't think I can reproduce this effect with only Refined Storage installed. If you think it's helpful, I can try to reproduce this outside of ATM10, with just IF, MIFA and RS2 installed, however since the whole thing relies on the ingredient insertion order which is outside of my control, I don't know that I would be able to force it.
What Minecraft version is this happening on?
Minecraft 1.21.1
What NeoForge or Fabric version is this happening on?
NeoForge 21.1.172
What Refined Storage version is this happening on?
2.0.0-beta.2
Relevant log output
[01:22:16] [Server thread/WARN] [co.re.re.ne.au.ItemHandlerExternalPatternProviderSink/]: com.hrznstudio.titanium.component.inventory.MultiInventoryComponent$MultiInvCapabilityHandler@6d69ec3e unexpectedly left [1 industrialforegoing:efficiency_addon_tier_2, 1 alltheores:netherite_gear, 1 minecraft:ancient_debris, 1 minecraft:netherite_scrap, 2 minecraft:blaze_rod] as a remainder, which has been voided
[01:22:16] [Server thread/WARN] [co.re.re.ap.au.ta.ExternalTaskPattern/]: Sink com.refinedmods.refinedstorage.api.network.impl.node.patternprovider.PatternProviderNetworkNode@4eb11e17 did not accept all inputs for pattern Pattern[id=9ce501ab-a59b-4e81-bb50-78ff3ba8cb5a, layout=PatternLayout[ingredients=[Ingredient[amount=1, inputs=[ItemResource[item=minecraft:ancient_debris, components={}]]], Ingredient[amount=1, inputs=[ItemResource[item=minecraft:netherite_scrap, components={}]]], Ingredient[amount=1, inputs=[ItemResource[item=minecraft:glass_pane, components={}]]], Ingredient[amount=1, inputs=[ItemResource[item=minecraft:glass_pane, components={}]]], Ingredient[amount=1, inputs=[ItemResource[item=alltheores:netherite_gear, components={}]]], Ingredient[amount=1, inputs=[ItemResource[item=industrialforegoing:efficiency_addon_tier_2, components={titanium:augments=>{Efficiency=0.8}}]]], Ingredient[amount=1, inputs=[ItemResource[item=minecraft:blaze_rod, components={}]]], Ingredient[amount=1, inputs=[ItemResource[item=minecraft:blaze_rod, components={}]]], Ingredient[amount=3000, inputs=[FluidResource[fluid=industrialforegoing:pink_slime, components={}]]]], outputs=[ResourceAmount[resource=ItemResource[item=mifa:efficiency_addon_3, components={titanium:augments=>{Efficiency=0.7}}], amount=1]], type=EXTERNAL]]This is a known issue, it will be fixed soon. Until then, you can make the crafter output into a chest (or something with a tank, a backpack with fluid upgrade works for me), then pipe the items in