Sometimes crashes when dismantling a network receiver
miku1881 opened this issue · 4 comments
Describe the bug
Sometimes it crashes when you dismantle a network receiver.
Not only that, but sometimes the cables remain when you dismantle them.
When I connect the chest and cable to the network receiver, it feels like the network receiver, which is supposed to be connected, has been disconnected.
The first log is the log when a crash occurs
The second log is when a cable is attached to the exporter network receiver side in the chest.
How can we reproduce this bug or crash?
1.Dismantled the network receiver
2.Minecraft crashed
What Minecraft version is this happening on?
Minecraft 1.21.1
What NeoForge or Fabric version is this happening on?
21.1.185
What Refined Storage version is this happening on?
2.0.0 beta-2
Relevant log output
This issue has caused frequent crashes on my friend’s server. I investigated and traced the problem to the algorithm for finding the network hub and how network merging is handled.
Currently, the algorithm selects the node with the smallest coordinates among all connected nodes as the network hub. When a network receiver from [Network 1] connects to another [Network 2] (even just a cable) whose coordinates are smaller than the receiver’s, the receiver gets merged into [Network 2]. This breaks the connection between the network sender and [Network 1].
If further operations are performed on [Network 2]—such as merging it back into [Network 1] with a cable or adding components to it—it may result in crashes or blocks that cannot be removed (with a "no permission" message).
The issue becomes even more apparent when two network receivers from different networks are connected to each other.
Duplicate of #949
Should note I ran into the same issue today for my locally hosted server, immediately the server crashed after I broke the network receiver.
Attached is my logs: https://mclo.gs/zsVmAwm