Refined Storage

Refined Storage

77M Downloads

Breaking a full Disk Drive only drops the Drive, no disks are dropped.

tolly765 opened this issue ยท 16 comments

commented

Issue description: If you break a RS Disk Drive and it contains some storage drives, it will void the disks and only drop the drive block.

What happens: When you break the block (assuming it has disks in it), it will only drop the block and delete the disks inside. Nothing else drops on the floor.

What you expected to happen: When the drive is broken, it's meant to drop the drive block AND the disks as well

Steps to reproduce:

  1. Get an RS system (specifics don't matter, as long as it has a Drive, some disks, the controller and a way of putting items into the disks).

  2. Break the drive block (creative/survival, tool/bare fist, it doesn't matter)

  3. Observe the damage.
    ...

Version (Make sure you are on the latest version before reporting):

  • Minecraft: 1.10.2
  • Forge: 8.0.99.99 (Latest Recommended version in FTB Beyond)
  • Refined Storage: 1.2.25 (Latest Recommended version in FTB Beyond)

Does this issue occur on a server? [yes/no] Yes

commented

Any logs?

commented

We've scanned through the logs ourselves, but nothing has actually come up in them.

commented

@tolly7654 he meant post your log so he can look.

commented

I'll see if I can provide a log then, but no promises on it coming in the next ten minutes. Internet isn't the greatest for me atm

commented

I'd like to scan the log myself, please only send a single relevant one.

commented

Or perhaps even better, send a recent log (so we're sure it's the right log) when you break a disk drive.

commented

Gonna see if I can do that then @raoulvdberge. Again, my internet isn't the greatest so I apologise if it takes a little while

commented

No problem, I'll take a look as soon as you upload it. No hurry.

commented

There is not generating any exceptions or anything there can show what the issues is when the item is broken.

If it is any help we are running sponge

commented

Seems like a typical Sponge issue to me.

commented

Well it might be a sponge issue, but the problem doesn't happen with enderIO or any of the other mods where this behavior is expected

commented

@raoulvdberge typical sponge issue? please explain.

commented

Sponge does things differently than Forge in some cases. In case of fragile code like TE inventory contents dropping (which relies on order of execution), I can see it doing something incompatible than what Forge mods rely on.

commented

thanks for the info. i have seen reports where items do not drop properly because of sponge.

commented

RS also does some extra work before the block is broken, like saving disk data before dropping, which might also cause issues.

commented

I'm going to close this, as I can't reproduce this.

Reasons could be:

  • Sponge compatibility
  • External mod causes the drops to not be dropped