Refined Storage

Refined Storage

115M Downloads

Crash when clicking encoded pattern on dedicated server (ClientPlayNetworking called in server env)

Closed this issue · 1 comments

commented

When on a dedicated server and encoding a pattern in the pattern grid and then left-clicking to pick up the pattern, to then place it in my inventory, the pattern disappears and gives me the error below.

However, shift-clicking works fine, so I am assuming this is to do with the different methods used between container item moving.

Normal dragging and shift clicking both work on singleplayer.

Info:
Fabric version
Refined storage v2.0.0
Minecraft v1.21.1
Fabric Loader v0.17.2
Fabric API v0.116.6

Steps to Reproduce

Run a dedicated Fabric server with Refined Storage 2.0.0.
Place and open a Pattern Grid connected to a working RS network.
Insert a blank pattern and encode any recipe.
Left-click the resulting encoded pattern to pick it up and move it into your inventory.

Result:

The pattern disappears.
Server prints a stack trace and suppresses the error.
The server stays running, but the container desynchronizes.

Expected:

The pattern should move safely to the player’s inventory (like in singleplayer).

[13:41:39] [Server thread/ERROR]: Failed to handle packet net.minecraft.class_2813@2bedb99e, suppressing error net.minecraft.util.crash.CrashException: Container click at knot//MC/net.minecraft.screen.ScreenHandler.onSlotClick(ScreenHandler.java:304) ~[server-intermediary.jar:?] at knot/com.refinedmods.refinedstorage.common.support.AbstractBaseContainerMenu.onSlotClick(AbstractBaseContainerMenu.java:131) ~[refinedstorage-fabric-2.0.0(1).jar:?] at knot/com.refinedmods.refinedstorage.common.support.containermenu.AbstractResourceContainerMenu.onSlotClick(AbstractResourceContainerMenu.java:138) ~[refinedstorage-fabric-2.0.0(1).jar:?] at knot//MC/net.minecraft.server.network.ServerPlayNetworkHandler.onClickSlot(ServerPlayNetworkHandler.java:1722) ~[server-intermediary.jar:?] at knot//MC/net.minecraft.network.packet.c2s.play.ClickSlotC2SPacket.apply(ClickSlotC2SPacket.java:71) ~[server-intermediary.jar:?] at knot//MC/net.minecraft.network.packet.c2s.play.ClickSlotC2SPacket.apply(ClickSlotC2SPacket.java:14) ~[server-intermediary.jar:?] at knot//MC/net.minecraft.network.NetworkThreadUtils.method_11072(NetworkThreadUtils.java:27) ~[server-intermediary.jar:?] at knot//MC/net.minecraft.server.ServerTask.run(ServerTask.java:18) ~[server-intermediary.jar:?] at knot//MC/net.minecraft.util.thread.ThreadExecutor.executeTask(ThreadExecutor.java:162) ~[server-intermediary.jar:?] at knot//MC/net.minecraft.util.thread.ReentrantThreadExecutor.executeTask(ReentrantThreadExecutor.java:23) ~[server-intermediary.jar:?] at knot/net.minecraft.server.MinecraftServer.executeTask(MinecraftServer.java:864) ~[server-intermediary.jar:?] at knot/net.minecraft.server.MinecraftServer.executeTask(MinecraftServer.java:173) ~[server-intermediary.jar:?] at knot//MC/net.minecraft.util.thread.ThreadExecutor.runTask(ThreadExecutor.java:136) ~[server-intermediary.jar:?] at knot/net.minecraft.server.MinecraftServer.runOneTask(MinecraftServer.java:846) ~[server-intermediary.jar:?] at knot/net.minecraft.server.MinecraftServer.runTask(MinecraftServer.java:840) ~[server-intermediary.jar:?] at knot//MC/net.minecraft.util.thread.ThreadExecutor.runTasks(ThreadExecutor.java:145) ~[server-intermediary.jar:?] at knot/net.minecraft.server.MinecraftServer.runTasks(MinecraftServer.java:810) ~[server-intermediary.jar:?] at knot/net.minecraft.server.MinecraftServer.mixinextras$bridge$method_18857$296(MinecraftServer.java) ~[server-intermediary.jar:?] at knot/net.minecraft.server.MinecraftServer.wrapOperation$cje000$modernfix$managedBlock(MinecraftServer.java:2123) ~[server-intermediary.jar:?] at knot/net.minecraft.server.MinecraftServer.runTasksTillTickEnd(MinecraftServer.java:815) ~[server-intermediary.jar:?] at knot/net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:702) ~[server-intermediary.jar:?] at knot/net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:281) ~[server-intermediary.jar:?] at java.base/java.lang.Thread.run(Thread.java:1583) [?:?] Caused by: java.lang.RuntimeException: Cannot load class net.fabricmc.fabric.api.client.networking.v1.ClientPlayNetworking in environment type SERVER at net.fabricmc.loader.impl.transformer.FabricTransformer.transform(FabricTransformer.java:62) ~[fabric-loader-0.17.2.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPreMixinClassByteArray(KnotClassDelegate.java:475) ~[fabric-loader-0.17.2.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:428) ~[fabric-loader-0.17.2.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:336) ~[fabric-loader-0.17.2.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:231) ~[fabric-loader-0.17.2.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119) ~[fabric-loader-0.17.2.jar:?] at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[?:?] at knot/com.refinedmods.refinedstorage.fabric.PlatformImpl.sendPacketToServer(PlatformImpl.java:378) ~[refinedstorage-fabric-2.0.0(1).jar:?] at knot/com.refinedmods.refinedstorage.common.PlatformProxy.sendPacketToServer(PlatformProxy.java:211) ~[refinedstorage-fabric-2.0.0(1).jar:?] at knot/com.refinedmods.refinedstorage.common.support.containermenu.ValidatedSlot.setStackNoCallbacks(ValidatedSlot.java:532) ~[refinedstorage-fabric-2.0.0(1).jar:?] at knot/com.refinedmods.refinedstorage.common.autocrafting.patterngrid.PatternGridContainerMenu$3.setStackNoCallbacks(PatternGridContainerMenu.java:222) ~[refinedstorage-fabric-2.0.0(1).jar:?] at knot//MC/net.minecraft.screen.slot.Slot.setStack(Slot.java:66) ~[server-intermediary.jar:?] at knot//MC/net.minecraft.screen.slot.Slot.tryTakeStackRange(Slot.java:125) ~[server-intermediary.jar:?] at knot//MC/net.minecraft.screen.ScreenHandler.internalOnSlotClick(ScreenHandler.java:418) ~[server-intermediary.jar:?] at knot//MC/net.minecraft.screen.ScreenHandler.onSlotClick(ScreenHandler.java:294) ~[server-intermediary.jar:?] ... 22 more~

commented

Update Cable Tiers to the newest version