Refined Storage

Refined Storage

77M Downloads

Crash when trying to autocraft an item from Scannable mod.

calloatti opened this issue ยท 5 comments

commented

Issue description:

When trying to autocraft an item from Scannable the game crashes.

This may be a Scannable issue, posting here just in case.

What happens:

When trying to autocraft a "Scanner module:block" from the mod Scannable the game crashes when hovering or clicking the mouse on the pattern in a crafting grid.

The patterns are stored in a RebornStorage crafter.

What you expected to happen:

Not crashing.

Steps to reproduce:

  1. Create a pattern for "Blank scanner module" from Scannable
  2. Create a pattern for "Scanner module:block" from Scannable
  3. Place both patterns in RebornStorage crafter
  4. Open Crafting Grid GUI, scroll to find "Scanner module:block" item
  5. Hover mouse or click over item, game crashes

image

image

image

Version (Make sure you are on the latest version before reporting):

  • Minecraft: 1.10.2
  • Forge:v12.18.3.2297
  • Refined Storage:refinedstorage-1.2.25
  • Scannable: Scannable-MC1.10.2-1.3.0.15

Does this issue occur on a server? [yes/no]

Not tested

If a (crash)log is relevant for this issue, link it here:

https://paste.ee/p/shWjf

https://paste.ee/p/WlMv2

commented

It seems like it only works with the blank scanner module. All the other modules based on the blank one seem to crash. (only tested one more since it takes forever to reload MC in my PC)

image

commented

java.lang.IllegalArgumentException: Module not supported by this provider: 0xitem.scannable.module_block@0 at li.cil.scannable.client.scanning.ScanResultProviderBlock.getEnergyCost(ScanResultProviderBlock.java:110)

Might be something with scannable not supporting stacksizes of zero.

commented

Ah yeah, for empty stacks my "is this an item of this type" check fails (because it checks isEmpty), and then it falls through to the exception. Will add a check to prevent this.

commented

@fnuecke in 1.11 RS doesn't use 0 stacks anymore, but this bug report is for 1.10. There is no isEmpty on 1.10

commented

Right. I have a wrapper that basically does what isEmpty does in 1.10 to make it easier to maintain the two versions alongside each other. I'll add a check in both MC versions either way, just in case.