Lag when shift-click crafting with Crafting Grid
piepie62 opened this issue ยท 7 comments
Issue description:
This may not be fixable easily, but when I craft a bunch of modded blocks (Tiny Progressions bone block, Extreme Reactors reactor casing, Mystical Agriculture inferium block, etc) with shift-click on the crafting grid, the server lags for a while; a couple times it has lagged for over 40 seconds.
NOTE: I have tested with vanilla blocks (gold, iron, diamond) and this has not occurred.
What happens:
Lag
What you expected to happen:
No lag
Steps to reproduce:
- Craft a lot of blocks (iron, gold, diamond, etc)
Version (make sure you are on the latest version before reporting):
- Minecraft: 1.10.2
- Forge: 12.18.3.2281
- Refined Storage: 1.2.25
Does this issue occur on a server? yes
If a (crash)log is relevant for this issue, link it here:
This is happening in SkyFactory 3.0.10
Oh, now I managed to get a stall report about this. Just thought it might be helpful.
Sorry, didn't know how to do that. Looking through issues allowed me to figure it out, but I suggest that you add the link to that one thread into your response in the future. :)
Here is a profiling report, using Inferium essence to Inferium blocks.
Just noticed, some other things, like vanilla fermented spider eyes, are doing this too.
Here is another report, this time using bones to Tiny Progressions bone blocks. From what I can understand from my very limited and literally picked up about ten minutes ago understanding, most of the overhead is coming from your ItemStorageExternal.detectChanges() method? I'm going to try doing it with something that isn't in my bank of drawers.
Looking at this report, this time converting dirt to compressed dirt, it seems that the most lag is coming from ItemStorageCache.remove().
This lag is caused by #1245.