Refined Storage

Refined Storage

Mods
77M Downloads

Detector "Signal on being Autocrafted" does not work as Subcraft

LeonGiering opened this issue ยท 4 comments

commented

Issue description:

When using the Detector in "Signal on being Autocrafted" Mode, the signal is only active when i request that item. It does not work when the item is a subcraft for another request. I am not sure if this is intended or not but it would be cool to have this feature.

Version :

  • Minecraft:1.12
  • Forge:14.21.1.2413
  • Refined Storage:1.5.12
commented

This is intended.

commented

@way2muchnoise How hard would this be to implement?

commented

I have no clue how that works exactly, but I'm guessing it shouldn't be to hard.

commented

This is how it currently works:

                        boolean found = false;

                        for (ICraftingTask task : network.getCraftingManager().getTasks()) {
                            for (ItemStack output : task.getPattern().getOutputs()) {
                                if (API.instance().getComparer().isEqualNoQuantity(slot, output)) {
                                    found = true;

                                    break;
                                }
                            }

                            if (found) {
                                break;
                            }
                        }

                        powered = found;

Not sure how easy it is to include the subtasks as well...