[1.11.2] Incompatibility with CarryOn
Tschipp opened this issue ยท 7 comments
Issue description:
Blocks from RS crash the game when the are placed via CarryOn
What happens:
Carry On tries to rotate every block before it is placed. It does this by going through all the Properties and then determining if the prop is instanceof PropertyDirection. Your blocks seem to have this PropertyDirection, so a flag is set to true.
Later, if that flag is true, it tries to adjust the rotation by calling
state.withProperty(BlockDirectional.FACING, facing.getOpposite()
.
This then crashes the game and claims that there is no PropertyDirection on the block. I'm not sure why this is happening. Is the error on CarryOn's end? It works with most other mods.
What you expected to happen:
It places the block and adjusts the rotation.
Steps to reproduce:
- Pick up Block like Controller with Carry On
- Place
Version (make sure you are on the latest version before reporting):
- Minecraft: 1.11.2
- Forge: 13.20.1.2386
- Refined Storage: 1.4.20
Does this issue occur on a server? [yes/no]
Yes, but also on SP
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]
https://pastebin.com/Ske200uL
Edit 2:
You should probably make sure that the TileEntity is not null in BlockDiskDrive.breakBlock, because it's throwing a null pointer exception, because CarryOn removes the TileEntity before the block is removed.
Dont do that! This is the type of shit that breaks worlds and mods. RS does critical stuff in breakBlock.
The thing is, I don't want it to drop the contained items. Carry On retains the items inside. Would you know of another way of removing the block but not dropping the contents of the TE?
Nope, but your current way is much worse than having the item drops.
Im 100% sure this mod gave lots of modders headaches already x.x