Autocrafting Server closed
ejjo01 opened this issue ยท 9 comments
Issue description:
I know my english is bad
if i in a autocrafting prozzess, Server closed
What happens:
i have an interface with 2 item for Export. on the top is an external storage (export only) in the interface is a crafting upgrade. the 2 item are yellow petal and tall yellow flower. i want to stack 16 in the system. if i take the 16 out the system. the crafting prozess are starting and the server closed.
What you expected to happen:
Steps to reproduce:
...
Version (make sure you are on the latest version before reporting):
- Minecraft:1.12.2
- Forge:14.23.0.2544
- Refined Storage:1.5.25
- refinedstorageaddons: 0.2
Does this issue occur on a server? [yes/no] yes
If a (crash)log is relevant for this issue, link it here:
Accoutering in MC 1.10.2 as well. No fix found.
I have the same issue on the same craft
I have removed the option "oredict" and it solve the issue.
It's a workaround but seems a bug with oredict.
PS: Disable "processing" it's not a craft in a machine.
PS: Disable "processing" it's not a craft in a machine
Uhh yeah, that's a screenshot derp, it definately was not configured as a processing recipe.
The circular dependency checking basically checks if a same pattern is used multiple times.
Can you retry with the latest version? The circular dependency message will display the offending pattern as well.
Regarding your crash, it seems unrelated to the circular dependency problem.
(Also - "regular" patterns do not rely on the ore dictionary for crafting when "oredict" mode is turned on. It uses the available ingredients that the recipe provides for that in MC 1.12+ (see Ingredient API). Are you sure the pattern wasn't misconfigured to be "processing"?)
Okay good news, I've isolated the problem for you in a test world with just refined storage latest (refinedstorage-1.5.31.jar), and a clean refined storage system.
Steps to reproduce:
- Set up a crafter with the following two recipes (used for vanilla crafting)
Recipe 1: green dye + white dye = lime dye (uses Ore Dict enabled)
Recipe 2: 1 bone = 3 bone meal (uses Ore Dict enabled)
- Set up the items in storage as the following:
Items in storage: bones, bone meal. - Try to craft lime dye. This fails with a circular dependency error (might be correct, as it might be seeing dye + dye = dye (whatever dye that might be)).
- Now remove the bone meal (so only bone is left).
- Try craft lime dye. This is now allowed:
- If you press 'Start', it will go mad on crafting bonemeal, and after a few seconds the game will crash with the crash log I posted.
Also note that it also doesn't ask for missing green dye in step 5.
Got this in the DW20 pack as well:
I can explain a bit what happened in my case, it might be helpful:
- I had just added a recipe: 1 bone -> 6 bone meal with a crafter + importer on a TE Pulverizer (crafter was existing already for other recipes).
- I let the autocrafting create craft 36 items involving the bone meal.
- It only crafted 32 items, and basically was stuck on the last set to craft.
- After investigation, it seemed the autocrafting went crazy, and kept adding bones one by one in the pulverizer, and I had plenty bone meal to do the last craft.
- I canceled the autocrafting operation.
- I restarted the autocrafting operation for the last 4 items, expecting not having to do any processing steps. This is when it crashed.
It might be related to the crash, because the autocrafting definately behaved weirdly, not crafting the last set in step 3 and 4.
//Update
After restarting, and seeing if I could reproduce it:
7. Tried to restart the crafting operation, got the following, which I'm sure I did not get before:
8. There shouldn't be any circular dependencies, for dyes I only have the following recipe:
cactus green + bone meal = lime dye (Ore dict support enabled)
And the recipe I was trying to craft:
9. I was suspecting something with ore dict, so I tried disabling the ore dict support on the recipe from the screenshot. This worked, no circular dependency.
10. The recipe still didn't craft, but that was because there was only 1 cactus green left and I didn't set up a recipe for that yet (which would explain why only 32 of the 36 items could be crafted in step 3).
It feels to me like ore dictionary handling might be the cause of this, maybe the fact that dyes are 'dyeGreen', but also in a generic 'dye' section. Could it be that the autocrafting incorrectly detects a circular dependency because of that (as I have a dyeGreen + dyeWhite = dyeLime recipe as well)?
Let me know if you need more info.
Still having this problem in 1.5.31
Crashlog: https://pastebin.com/pYUD6FKg