Refined Storage

Refined Storage

Mods
77M Downloads

Disk Drive with more than MAX_INT of storage on combined disks shows wrong value

Lordmau5 opened this issue · 3 comments

commented

Issue description:

If you have disks in the Disk Drive that exceed MAX_INT of total storage, it wraps back to MIN_INT showing negative values in the GUI.

What happens:

image

What you expected to happen:

It should show a properly formatted value, but it can't due to exceeding MAX_INT.
A suggestion would be to use long for solely this calculation (perhaps more if it's needed).

Steps to reproduce:

  1. Use a mod like Quantum Storage that adds disks that exceed MAX_INT if combined
  2. Place 2 in the Disk Drive

Version (make sure you are on the latest version before reporting):

  • Minecraft: 1.12.2
  • Forge: 14.23.1.2599
  • Refined Storage: 1.5.31

Does this issue occur on a server?

  • Yes
  • No
commented

I’m a fan of BigInteger myself.

commented

I just read up on BigInteger myself and it seems to be a better fit.

Also, I just realized that this would additionally need to address the Grids to show the value in BigInteger, too.
image

commented

Will tag this as wontfix as this is not possible to do in RS due to ItemStack's being limited to int size.