Refined Storage

Refined Storage

77M Downloads

Crafting calculation causing stall

jediminer543 opened this issue ยท 4 comments

commented

Issue description:

Crafting calculation causes server side stall

What happens:

A crafting request is made by an exporter, which results in a stuck server thread

What you expected to happen:

My game to not die in a fire

Steps to reproduce:

  1. Placed an export bus down with a crafting card, told to craft wooden planks
  2. Game immediatly dies

It is possible that this is due to the exporter having OreDict enabled, and all the wood crafting recipes having OreDict enabled, but that should throw an error to the user not hang the server

Version (make sure you are on the latest version before reporting):

  • Minecraft: 1.12.2
  • Forge: 14.23.1.2587
  • Refined Storage: 1.5.31

Does this issue occur on a server? Haven't checked

Logs:

stall-2018-02-19_21.43.51-3.txt
stall-2018-02-19_21.41.50-2.txt
stall-2018-02-19_21.40.50-1.txt
stall-2018-02-19_21.40.19.txt

Etc.

They all show an issue in apiimpl.autocrafting.CraftingManager.hasPattern is causing hang, if I am interpreting them correctly.

NOTE: This cannot be profiled, as the server side immediately hangs on occurance

commented

I can't do much with this report.

commented

Sorry, is there anything else I can add to make it more usefull?

commented

These set of performance issues will be fixed later anyway if I ever rewrite the autocrafting.

commented

No.