Issue description:

Crafter inserting into botania:opencrate gives the following warning in server log and autocraft stalls without completing:

[Server thread/WARN] [com.raoulvdberge.refinedstorage.apiimpl.autocrafting.task.CraftingTask]: In a simulation, vazkii.botania.common.block.tile.TileSimpleInventory$SimpleItemStackHandler@5204242d reported that we could insert 1xitem.manaResource@1 but we got 1xitem.manaResource@1 as a remainder

I appreciate the dev team have done a lot of work around the way autocrating works recently. It used to be possible to autocraft into botania opencrates in previous versions, it would be great if this could be made possible again.

What happens:

(as above)

What you expected to happen:

Crafter inserts each ingredient into botania:opencrate as per pattern recipe.

Steps to reproduce:

1. Create a crafting pattern for either botania petal apothecary, botania runic altar or botania agglomeration table
2. Place crafter to insert into botania:opencrate and insert crafting pattern into crafter
3. Order required item
   ...

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: forge-1.12.2-14.23.5.2768-universal
• Refined Storage: refinedstorage-1.6.7.jar

Does this issue occur on a server? [yes/no] yes

If a (crash)log is relevant for this issue, link it here:

[Server thread/WARN] [com.raoulvdberge.refinedstorage.apiimpl.autocrafting.task.CraftingTask]: In a simulation, vazkii.botania.common.block.tile.TileSimpleInventory$SimpleItemStackHandler@5204242d reported that we could insert 1xitem.manaResource@1 but we got 1xitem.manaResource@1 as a remainder

[pastebin/gist/etc link here]

@raoulvdberge Doesn't seem ideal to void items. is it possible to only remove items from storage if they will fit in the destination inventory. Or return to storage anything that wouldn't fit?

It would also be nice if you tried to insert the remainder on the next crafting tick.

Can I see a screenshot of the pattern that is causing the problem? The inputs/outputs/etc.

Does it keep spamming that log?

No, just the one message

Edit: one message per requested autocraft. The requested craft/recipe does not complete and has to be cancelled via the crafting monitor.

Hope this works and helps...
https://imgur.com/zeWc0d3

Edit: fyi, the first item of the recipe gets correctly inserted, the remainder do not. In an older version of RF, 1.5.34 (I think), the crafter used to insert items one at a time in order of the pattern, which was useful for trying to craft with the Draconic Infuser, as the first item was always in slot 1 and was the item that needed routing to the Crafting Core, with the remaining items distributed to each Fusion Crafting Injector. I notice now, that RF seems to attempt to insert every item at once, and in no particular order. Any crafting that involves 'blocking' is now terribly complex. Not sure if this is your intention or not.

Anyway, thanks for your help, keep up the great work, on a great mod.

Blocking is in again, with the crafter redstone mode.

https://refinedstorage.raoulvdberge.com/wiki/locking-and-unlocking

Yes thanks, I have been trying it out. Complicated redstone required, but works well otherwise. I have been using ComputerCraft turtles as the crafter receivers, which can easily return the redstone pulse required for the next recipe items. I would welcome your thoughts on how you intended it to work. BTW I had already read your wiki page, which helped a lot. Great work :)

Thx!

Can you reproduce your problem 100% of the time?

Yes. Any recipe that attempts to insert more than one item into a botania:opencrate produces the problem (unless the recipe only consists of one item).

I know what causes this. I am working on a fix.

I'm having a similar issue: I'm on RS v1.6.5 and attempting to insert a recipe into a machine with a single inventory slot. I would expect each different item stack in the recipe to be inserted one at a time (due to lack of space) but instead the recipe aborts. It also kills the RS subnet the crafter is attached to and I need to reconnect it.