Refined Storage

Refined Storage

Mods
77M Downloads

OC integration throwing errors

Garagoth opened this issue ยท 0 comments

commented

https://github.com/raoulvdberge/refinedstorage/blob/68e857cc9c32f996c599db4223e38267e45f66b8/src/main/java/com/raoulvdberge/refinedstorage/integration/oc/ConverterCraftingPattern.java#L16

getByproducts throws IllegalStateException if this is a processing pattern; OC integration does not check this and spams logs with exceptions:

[20:22:19] [Server thread/WARN] [opencomputers]: Type converter threw an exception.
java.lang.IllegalStateException: Cannot get byproduct outputs from processing pattern
        at com.raoulvdberge.refinedstorage.apiimpl.autocrafting.CraftingPattern.getByproducts(CraftingPattern.java:205) ~[CraftingPattern.class:?]
        at com.raoulvdberge.refinedstorage.integration.oc.ConverterCraftingPattern.convert(ConverterCraftingPattern.java:16) ~[ConverterCraftingPattern.class:?]
        at li.cil.oc.server.driver.Registry$$anonfun$convertRecursively$1.apply(Registry.scala:203) [Registry$$anonfun$convertRecursively$1.class:?]
        at li.cil.oc.server.driver.Registry$$anonfun$convertRecursively$1.apply(Registry.scala:203) [Registry$$anonfun$convertRecursively$1.class:?]
        at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) [ResizableArray$class.class:?]
        at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48) [ArrayBuffer.class:?]
        at li.cil.oc.server.driver.Registry$.convertRecursively(Registry.scala:203) [Registry$.class:?]

MC 1.12.2
RS 1.6.9
OC 1.7.2.67