Refined Storage

Refined Storage

77M Downloads

[Suggestion] Add player starting the crafting, to the dummy container

mcenderdragon opened this issue ยท 4 comments

commented

right now the container supplied to InventoryCrafting (used to get the crafting recipes & result) is empty and does not contain the player who requsted these items. As I have crafting recipes which are locked for players I am unable to determine who wants to craft and thus all recipes are blocked from RS automation.

Edit: maybe GameProfile is better incase the recipes takes longer and the player goes offline?

commented

Are we talking about autocrafting or the crafting grid

commented

Some thoughts.
I don't think it makes sense to allow for "workarounds" using autocrafting. So both autocrafting and the crafting grid would need to work for this.

There are 2 ways I can think of making it work.

A) The player that is using the grid is selected for this. There are a couple of edge cases in the crafting grid that might be tricky but I think there are solutions for them. This also means passing the player with each crafting request, providing feedback if requests fail, etc.

B) The player that places the controller. Fairly straightforward. Not as clean for multiplayer as people may start reporting bugs when they are unable to craft things because their AFK teammate hasn't progressed yet.

Haven't looked at code but while A sounds difficult it doesn't seem impossible. B is kinda the easy way out.

commented

At best both, since right now the crafting grid of RS can not craft these items. I dont know if its possible to provide a crafting player for all cases though.

commented

I would be totally happy with B as it is better compared to the current solution.