Refined Storage

Refined Storage

77M Downloads

Crashing due to taking more than 60 seconds to process 1 tick

jrnvnjk opened this issue · 3 comments

commented

Issue description:

Game crashes due to a single tick taking too long (60 seconds instead of 1/20 of a second)
I already had the same bug with a previous version when manualy crafting stuff with ingredients from the network, if you shift click too fast refined storage lags the system even crashes the game when you click too many times(the items appear in your inventory after the processing is done). A larger recipe(7-9 squares used) it will be noticable. Slowly clicking(waiting until it appears in your inventory) was a workaround for this bug to prevent it from crashing the game.

Now it's even happening when moving network stuff with the disk manipulator. So I cant use a workaround for it.

What happens:

The game crashes, or lags for a few second.

What you expected to happen:

Not to crash/lag.

Steps to reproduce:

  1. make a recipe in the crafting grid with 9 coal.
  2. ensure there are lots of coal in the system and your inventory is empty
  3. shift + repeadly leftclick on the block of coal to craft 64 blocks of coal into your inventory

...

Version (make sure you are on the latest version before reporting):

  • Modpack: Dungeons Dragons And Space Shuttles 7.4a
  • Minecraft:1.12
  • Forge:14.23.5.2847
  • Refined Storage:1.6.16

Does this issue occur on a server? yes

If a (crash)log is relevant for this issue, link it here:

https://pastebin.com/aKMH0ttc

If needed I could send you the save through for example weshare

commented

Unfortunately a watchdog crash report does not help with this. The watchdog just kills the game and it just happened to be the disk manipulator operating when this happened.

You would need to use a profiler like spark or sampler to confirm what the actual problem is.

That said shift crafting is expensive. Especially if the items are coming out of an external storage. There is not really anything we can do against it. Use autocrafting.

commented

Fixed this in my fork if anyone wants this fixed.

commented