Refined Storage

Refined Storage

107M Downloads

Huge performance issues during rain

ChloeDawn opened this issue ยท 4 comments

commented

Issue description:

Performance is impacted significantly during rain

What happens:

This line here - and similar lines in the other block classes - causes particle collision to grind to a near halt.

shape = VoxelShapes.or(shape, getHeadShape(state));

What you expected to happen:

I expect performance during rain to be identical to performance during clear weather.

Steps to reproduce:

  1. Create a storage network with various cables and constructors, exporters, etc.
  2. Toggle rain on.
  3. Hang around among the cables and devices.
  4. Observe performance drop.

Version (make sure you are on the latest version before reporting):

  • Minecraft: 1.15.2
  • Forge: 13.2.30
  • Refined Storage: 1.8.6

Does this issue occur on a server? Yes

commented

How did you come to this conclusion? Just tried and can't seem to reproduce this.

commented

The voxelshape code could use some caching.

commented

Here is a snapshot of the CPU time @Darkere
javaw_09-07-2020_11-45-40
image

commented

Fixed now. The shapes are now being cached during startup.