Refined Storage

Refined Storage

115M Downloads

Add branch name linting

raoulvdberge opened this issue ยท 6 comments

commented

With #264 we'll start using merge commits instead of rebase pushing when merging a PR.

That means that branch names will go in the history of develop

That also means that we probably need better branch name linting.

I propose

fix/GH-1234/alphanumeric-description-of-changes-no-uppercase
feature/GH-1234/alphanumeric-description-of-changes-no-uppercase

commented

What about refactors, just refactor/GH-1234/alphanumeric-description-of-changes-no-uppercase?

commented

Also we should not forget to document that

commented

I'm personally more in favor of branchnames like fix/1234-alphanumeric-description-of-changes-no-uppercase

commented

Yes needs to be documented in contributing

We can probably allow the same category names as used in commitlint?

commented

I like the GH prefix to clarify it's a GitHub issue (if we'd ever migrate to something else).

Also, GH makes a link out of it:
image

commented

We need to differantiate between release/hotfix branches and regular branches.

Release hotfix format should be release/SEMVER HERE or hotfix/SEMVER HERE.