Issue description:

What happens:

What you expected to happen:

the message to not be present since already set try in the config file already

Steps to reproduce:

just load the mod with forge 34.1.35 does not occur with 34.1.25 and below

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.16.3
• Forge: 34.1.35
• Refined Storage: refinedstorage-1.9.8.jar

Does this issue occur on a server? [yes/no]
not sure

Do you think there can be a solution to this issue? I'm not as deep into it, but I have CLL Log triggering a lot about disk drive (don't have any cables or anything more complex yet). I don't really care about that, but will it mess with more blocks? I have OptiFine since I have 1440p display and to be honest, I can't play on any vanilla Gui setting and it really helps with performance at the same time. So I would really like to keep it.

This is what Jared does to detect it.
https://github.com/jaredlll08/TipTheScales/blob/25ded3a4fb085aa04d669ee8c98f25a5ec24580c/src/main/java/com/blamejared/tipthescales/TipTheScales.java#L30

I tried detecting optifine at runtime but it didn't really work.

Probably not, since from what I've read OptiFine seems to be a very invasive mod. I suspect that it has to replace the lighting pipeline to be able to optimize things. Maybe, when the experimental pipeline is no longer experimental, OptiFine will finally add support for it.

It's unfortunate, because OptiFine is pretty much essential for getting high render distances on Linux.

Yes, Optifine replaces the entire lighting pipeline, without an option of disabling that functionality IIRC. So, that also means they can't support the experimental one. Not much that I can do about that on my end unfortunately.

I wonder if the disk drive is the only RS block which gets affected by this, because of the 3D drives feature. Perhaps it would be possible to fall back to 2D drive rendering if OptiFine is detected? Or does this affect other blocks as well?

I'm not really familiar with the modding scene - what are the chances of getting OptiFine to fix this lighting issue on their end?

Less than zero

Yes I know optifine wont do a thing about it. It's more of can someone else do but I understand if not. Also, could there be an option in optifine that if you turn it off it won't mess with it?

How do you access the config and what is the fix for the lighting issue every time I play now I lag a ton so I was hoping to fix it but I can't even get in this config.

The config is in .minecraft/config/forge-client.toml. The setting to change is experimentalForgeLightPipelineEnabled and it needs to be made true.

Thanks a ton

Is this a game breaking issue or will it just cause lighting issues with blocks?

From what I can tell, it has no impact on gameplay besides the strange rendering.

Could we at least have a config option in RS to disable the chat warning entirely (of course, defaulting to showing the warning)? It's a little annoying to see the naggy message every time you enter a world.

Any update on this?

Furthermore, LatvianModder said the current check won't even work on a dedicated server regardless of anything else (we were discussing it in his server):

Yeah, would love to see a dedicated config option to disable to the log output or something. Just for server managers at least. Having the same "issue" as above.

Likely relevant: sp614x/optifine#4171 (basically confirmation of WONTFIX from sp614x's end)

I don't know how unreasonable it is to require mod authors to not rely on experimental (and barely documented) Forge features...

FWIW some lighting weirdness can be mitigated by turning off Smooth Lighting (but of course this makes the lighting super unsmooth :P)

I mean, at the very least can we just turn off the warning? I know I've already personally requested this but it's a rather small feature to add and it's kinda silly that currently our hand is forced here.

I can confirm the same behavior with Forge 34.1.42 (same versions of everything else).

I can not reproduce this. Please ensure that you have restarted MC.

@raoulvdberge This still happens even after Minecraft is restarted multiple times; I have confirmed that the setting is set to true in config/forge-client.toml.

Are you sure that you've changed the correct option and then restarted? There are 2 lighting pipeline related configs.

	#EXPERIMENTAL: Enable the Forge block rendering pipeline - fixes the lighting of custom models.
	experimentalForgeLightPipelineEnabled = true
	#Enable the Forge block rendering pipeline - fixes the lighting of custom models.
	forgeLightPipelineEnabled = true

I copied these from my Forge config. They are the correct settings, right?

EDIT: Yes; I restarted after changing them.

That should work, yeah. Not sure what to do now as I can't reproduce it.

Did you try with just RS installed?

Thanks for that suggestion. I realized that I had included OptiFine in this modpack since I was trying to compensate for post-1.12 rendering performance loss. When OptiFine is included the message appears regardless of the Forge setting. I don't recall seeing a problem with RS blocks rendering though.

The experimental lighting pipeline is not compatible with Optifine, so I imagine Optifine is dynamically disabling it. Thanks for confirming that it's an Optifine issue though!

(Try placing a disk drive encased with dirt, the disk drive will be very dark)

Wow; the old lighting pipeline really is buggy. Is there a way to detect if OptiFine is present, and if so, print a warning message to the chat that Refined Storage is not compatible with OptiFine?

Not compatible is rather strong wording, I think I can change the nagging message a bit.

I do find it a bit ironic optifine/shaders aren't supported considering they're in almost all of the screenshots on the mods page haha

I believe the screenshots are from 1.12 or earlier but I could be wrong.

This is quite ridiculous, just provide a config option in refined storage to render the block without its fancy animated texture. I'm in a modpack in excess of 200 mods and these refined storage blocks are the only ones with rendering issues. Whilst it may be optifine's fault, every other mod can deal with it except refined storage, which is kind of hilarious.

To be fair to the RS devs, they may have opted for some process a long time ago that would now require a time-consuming rewrite to be compatible with Optifine.

What is not understandable is why they won't let us disable this textual warning, at our own risk. It seems illogical.

I'm going to remove this warning for the next version, as it causes more problems than it's worth.