Refined Storage

Refined Storage

77M Downloads

Config to block interations with certain inventories (Large inventories like Danks - dank mod causes lag on servers)

XxN4BxX opened this issue ยท 3 comments

commented

Issue description:

connection to very large inventories can cause server lag

What happens:

using external storage with very large inventories like Dank mod can cause very high amounts of lag on a server

What you expected to happen:

Config to block connection to certain inventories from other blocks "["mod:block"]"

Steps to reproduce:

1.make multiple networks and get docks from dank mod with a dank 5+ to act as storage with constant interation
2.play on a server with multiple mods with constant events
3.get huge drops on TPS
...

Version ():

  • Minecraft: 1.16
  • Forge:35.1.1
  • Refined Storage: 1.9.9

Does this issue occur on a server? [yes/no]
Yes

If a (crash)log is relevant for this issue, link it here:

[pastebin/gist/etc link here]

commented

Hmm can you please profile this lag to figure out what exactly is causing the lag here?

AFAIK Dank storage doesn't have that many more slots than a chest does.

commented

unfortunately im not the OP but we tested it together and we removed danks that were connected to the RS system and TPS went up, from what we discussed and though, but we are not sure is that Storage is reserving the spaces on the Dank and since things like Dank 6 can store 262114 items/blocks per slot we believe that Dank its treating that and making virtual slots for actual stacks and RS is capturing those as actual slots so, there are way more slots than a chest

either way having a config to block certain connections would be good anyway to avoid future bad events and/or exploits on servers

commented

Not sure if it is the same issue/behavior but what I have notice with Dank Storage connected to a Refined Storage:
Import: no issue
External storage: Often need to close and reopen the interface of the Crafting Grid because I can often not remove any item from the RS network. Just getting out/in of the Crafting Grid "fix" the problem but only for this interaction.