ice and fire banner
Spooks69 opened this issue ยท 15 comments
Issue description: textures for ice and fire banner patterns are corrupted
What happens: a pink line shows up at the bottom of the banner no matter pattern it is
What you expected to happen: the banner pattern work
Steps to reproduce:
- get any banner
- get any pattern from ice and fire and dye
- try combine them in a loom
...
Version (make sure you are on the latest version before reporting):
- Minecraft: 1.16.4
- Forge: 1.16.4 - 35.1.11
- Refined Storage: 1.9.9
Does this issue occur on a server? [yes/no] yes
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]
it breaks any custom banners from other mods, like mubble for 1.15.2
this ice and fire issue also happens in 1.15.2
it causes the issue, with a pack of 70+mods, only when i add refine storage it happens, even when im just using ice and fire and refined storage it breaks banners, also with mubble, it breaks mubble star pattern. when applying broken banner to a shield, it goes completely black
Minecraft: 1.16.4
Forge: 1.16.4 - 35.1.36
Refined Storage: 1.9.11
Ice and Fire and Additional Banners are messed up only when Refined Storage is in the mods folder...
So yes it is somehow making it impossible to have anything other then default patterns in the loom...
I don't know why it is happening either...
Having this issue as well. Latest versions of refined storage (1.9.12) and Ice and Fire
I'm having the same issue. The banner patterns from immersive engineering also break. version 1.9.12
I haven't posted anywhere else but i think the issue is with refined storage because as soon as i remove it the patterns from mods (ice and fire, immersive engineering, dark utilities, rats) apply correctly. None of them worked with refined storage present. I really cannot help you any more. I know nothing about modding. Also no logs since there is no crash.
Here is a log from the game. Tha last thing i did was apply a modded pattern to a banner if that helps.
https://pastebin.pl/view/4a528082
Okay so banner patterns from rats and alex's mobs mod are also affected in the 1.6.4 version.
Just do add some more information as to why this is happening:
Basically this piece of code gets called way before any item registration can take place (e.g banners). What it does is call Atlases#collectAllMaterials and this adds the banner textures to the "Banner atlas" but it does so before Ice and Fire registers it's items (and also banners/ banner textures).
After that the Atlas never gets generated again and therefore the new banner textures are missing.
If this is an issue Ice and Fire needs to deal with please let me know!
