Refined Storage

Refined Storage

107M Downloads

1.16.4 fluid autocrafting duplication bug

Thorjackie opened this issue ยท 4 comments

commented

Issue description:

fluid autocrafting 'duplicates' fluids stored both internally and externally when autocrafting by raising the 'stored' value of the fluid till autocrafting completes.

What happens:

when autocrafting with fluids, as soon as autocrafting begins, the 'stored' value of the fluid gradually goes up till it reaches a maximum ( which seems to be related to the amount of fluid storage present in the system ) or the autocrafting is complete. When autocrafting is done, the 'stored' value of the fluid remains, the 'crafting' won't complete until canceled, and all fluid containers, both fluid storage drives and external tanks, are filled with the 'stored' fluid, thusly duplicating it.

What you expected to happen:

When autocrafting with fluid, X number of mB are either stored or processed, used up, and autocrafting completes when processing does.

Steps to reproduce:

  1. create recipe that used fluid autocrafting (ie 1 empty bucket, 1 B lava, in a tank, to produce 1 lava bucket)
  2. craft with said recipe, from one bucket to many
  3. receive infinite fluid
    ...
    (Note this seems to happen only on bigger systems, I tried it in a fresh world with a minimal RS system, and I had no issues. This has happened to me on RS 1.9.8 on MC 1.16.3 as well, both times it only occurred when my RS system got larger.)

Version (make sure you are on the latest version before reporting):

  • Minecraft: 1.16.4
  • Forge: 35.1.13
  • Refined Storage: 1.9.9

Does this issue occur on a server? [yes/no]
yes ( tested on lan )

If a (crash)log is relevant for this issue, link it here:

no logs nor crashes are reported during the issue, however I can produce a video if need be.

Screenshots:
Autocrafting Setup:
autocrafting_setup

Autocraft Recipe:
autocraft_recipe

Tank Initial Amount:
tank_initial_amount

Autocraft Mid-craft:
autocraft_mid_craft

autocraft finished:
autocraft_finished

tank after autocrafting and autocraft is cancelled:
tank_autocraft_finished

commented

No need for video. I've seen this one once on stream already :/.
I was completely unable to reproduce it though.

Can you please make a list of things that are interacting with fluids in your system?

commented

update: this bug is elusive. I just logged back in, changed nothing about the system. tried autocrafting a bucket again, and it worked like a charm :/ I'm gonna keep trying to force it and report back

commented

Of course. I've used two setups to test this out in my main world. The first setup had a blast chiller and a fluid plenisher from thermal as autocrafting, my fluid storage was a mekanism tank. Trying to eliminate extraneous variables, removed the crafter on the blast chiller, and i replaced my fluid plenisher with a mekanism tank. The only other fluid external storage is connected to a cooking for blockheads sink for water. I replaced my storage tank with a 64k fluid storage drive and still had the same issue. When i get back i can see if removing the sink or disconnecting the bulk of my RS network has any effect. I will note, in my test world where it seemed to work fine, i also used a mekanism tank for storage and there were no issues.

commented

Was finally able to reproduce. To replicate insert fluid into the Cooking for blockheads sink and extract from that.

When we are trying to extract latex the sink returns a bucket of water if there was latex inserted into the sink beforehand.
This water gets turned into latex by us after.

Will report to them. And fix our conversion problem.