Refined Storage

Refined Storage

107M Downloads

[Improvement/1.12-1.16] Broaden compatibility for tooltip rendering

BloCamLimb opened this issue ยท 2 comments

commented

Issue description:

RenderUtils#drawTooltipWithSmallText leads to a poor compatibility to most of other mods

How to fix this:

See how Quark implement this:

  1. Add spaces lines along with ItemTooltipEvent
  2. Draw stuff along with RenderTooltipEvent.PostText

What you expected to happen:

Broaden tooltip rendering compatibility for Grid GUI by following steps above

Steps to reproduce:

See this issue

Version:

All Forge, RS versions from Minecraft 1.12.2 to 1.16.4

If code is relevant for this issue, link it here:

https://github.com/refinedmods/refinedstorage/blob/mc1.16/src/main/java/com/refinedmods/refinedstorage/util/RenderUtils.java#L102-L297

commented

I don't really agree with the "how to fix this", adding extra lines creates a too large tooltip (the line height is much bigger than that of small text).
RenderTooltipEvent also doesn't really have any facilities to alter the height of the tooltip.

commented

This has been fixed for RS 1.19.2+.
We are using the tooltip events now in combination with client tooltip components for the small text.