Most of the RS blocks lost their custom names when placed
Mooncat25 opened this issue ยท 2 comments
Issue description:
While most of the blocks in this mod can be renamed on anvil, they lost their custom names once they are placed.
What happens:
I tried to rename a Network Transmitter because I have too many of them and it's hard to keep track which one is paired with which Network Receiver without different names. Anvil showed it can be renamed. I renamed it. My player level was reduced. But its name returned to "Network Transmitter", as displayed by Jade, once I placed it on the world.
Also tried on clean environment and successfully reproduced it with other blocks.
What you expected to happen:
Either anvil shouldn't show they can be renamed, or, preferably, they keep their custom names like Crafter.
Steps to reproduce:
- Give yourself some RS blocks like Interface, Crafting Monitor, Network Transmitter, etc. besides Crafter.
- Rename them on Anvil
- Place them on the world
- Break them in survival mode
- Observe their names
Version (make sure you are on the latest version before reporting):
- Minecraft: 1.16.5
- Forge: 36.1.13
- Refined Storage: 1.9.12
- Refined Storage Addons: 0.7.2
Does this issue occur on a server? I don't know, I only play single player.
If a (crash)log is relevant for this issue, link it here:
(Not a crash issue)
Probably related to #2324, but in different version.
In vanilla, many/all(?) tile entities (chests, furnace, enchanting tables, ...) are an instance of LockableTileEntity
(which has the extra CustomName
attribute. For example, this is set using
onBlockPlacedByin
BlockChest. In RS, this could be implemented in
NetworkNodeBlockwhile the
CustomNameattribute could be implemented in
NetworkNodeTile.
GridScreen(and other screens) would then need to check for a custom name in
renderForeground`` and display that instead of the title.
(Additional features like the "Crafter" showing a different name in the Crafter Manager could also be added. Priority of the renamed Crafter over a potentially renamed machine it's pointed to should be fine.)
Overall, this feels more like a missing feature. While Vanilla MC does have this for basically all blocks with a GUI, not every block has it. (You can also rename Sand in an anvil. Place it, break it, and observe the custom name removed.)
(Maybe I'll try to implement this in the next few days but no promises.)