Refined Storage

Refined Storage

77M Downloads

Consider options to adjust to random NBT in processing recipes.

Darkere opened this issue ยท 7 comments

commented

Some mods crafting methods cannot predefine the NBT on the item. For example: klikli-dev/occultism#478
where the mod dev picks a random name each time the item is crafted.

This would be difficult to solve for regular crafting recipes, but for Processing recipes it might be possible?

commented

Hm, I don't really like this. We used to have this feature in 1.10 (I think?) where we stripped some parts of the NBT tag. But it made the code really messy and error-prone (e.g. forgetting to strip).

commented

I don't remember how it was back then. But this case would work by just not comparing NBT when checking whether this item is a correct result for this processing task.

return (singleItemSetToReceive.getCount(stack) * totalQuantity) - itemsReceived.getCount(stack);

Passing 0 as flag there would be all it takes on the autocrafting side.

Inputs are more problematic, as you can end up with recipes that sometimes work and other times not. Possible, but not without making it extremely clear what the problem is in the Crafting Monitor.

commented

I think it would just make it confusing to do it for outputs. Now we at least can reason about it.

commented

Hmm, if it's not just for outputs, it will put this at the end of the current todo list. I'll make a proposal on how this could work then :)

commented

For the inputs it should have a way to choose what you want to ignore like the alternatives. The good example is to use the "quantum entangled singularity" in recipies (what I think is already wrong, but designs right) so they come in pairs and the processing to the 1.9.x today will not ignore it so I need to keep changing the recipe as there's no way to ignore that NBT that make them a pair.

This can be target for the version 2.0 not now but it's something that I would like the team to keep in mind :)

Best mod ever!

commented

Hi,

One more for the books.. EnigmaticaModpacks/Enigmatica6#4714, I came here to check if there was a way to ignore the nbt.

Would be nice to have a feature to ignore nbt on some items recipes, but I see it might be challenging. Thanks for the mod.

commented

I'll make a proposal on how this could work then :)

Closing this for now, we can revisit this then.