Refined Storage

Refined Storage

Mods
77M Downloads

Make sure shift click extraction actually goes through

Darkere opened this issue ยท 1 comments

commented

Describe the bug

refinedstorage/src/main/java/com/refinedmods/refinedstorage/apiimpl/network/grid/CraftingGridBehavior.java

Line 122 in e3756e0

usedItems.getStacks().forEach(stack -> network.extractItem(stack.getStack(), stack.getStack().getCount(), Action.PERFORM));

If the extraction here fails, we are duping items. Particularly problematic if people have slots with more than 64 items, as the default implementation of ItemHandler#extractItem specifies Item.maxStackSize as the maximum that can be extracted at once.

How can we reproduce this bug or crash?

Occultism dimensional matrix, with max stack size override enabled in config.

What Minecraft version is this happening on?

Minecraft 1.16.5

What Forge version is this happening on?

36.2.22

What Refined Storage version is this happening on?

any

Relevant log output

No response

commented

Same issue