Refined Storage

Refined Storage

77M Downloads

DataParameter desync

Darkere opened this issue ยท 2 comments

commented

Describe the bug

When Addons register Parameters using this method:

public synchronized static void registerParameter(BlockEntitySynchronizationParameter parameter) {

There is a chance for desychronization. We added synchronized to fix it, however that only fixes the desync in Singleplayer. The desync still happens on servers as the order on the server may not be the same as on the client.

A potential option would be to change the Registry key from Integer to BlockEntityType. But this would be a breaking change for any addons using it.

How can we reproduce this bug or crash?

  1. Play RS on server and get "lucky".

What Minecraft version is this happening on?

Minecraft 1.19.2

What Forge version is this happening on?

43+

What Refined Storage version is this happening on?

1.11

Relevant log output

No response

commented

We could fix this in 1.19.3 sometime by the end of this month.

commented

Any known workaround for this or info about update? Ofc on serverside