Grid menu doesn't handle network changes
raoulvdberge opened this issue ยท 2 comments
Describe the bug
Watcher listeners become out of date + strategies too.
How can we reproduce this bug or crash?
- Place a grid
- Place a cable
- Place other blocks after the cable
- Put a destructor destroying the cable from step 2
- Open the grid quickly, before destructor from step 4 destroys cable from step 2
- Network is split, see what happens.
What Minecraft version is this happening on?
Minecraft 1.19.3
What Forge or Fabric version is this happening on?
latest
What Refined Storage version is this happening on?
latest
Relevant log output
No response
This issue was fixed for splits, but merges suffer from the same issue. The fix doesn't handle that.
- Place 2 sets of networks w/ grid, controller and storage (player facing north).
- Add a constructor with cable that will merge them.
- Left side will get a new network, so the grid view will get cleared on the left.
- However, only the storages from the left side will be re-synced as that is the only new storage that was added. Storage from the right already existed so that won't get re-added.
Fixed in #467