Disk manipulator emptied a disk to -448/64000
tivec opened this issue · 11 comments
Issue description:
I'm not quite sure what happened here, I have an EnderIO conduit feeding the disk manipulator for emptying the contents into the system. I have an EnderIO conduit extracting empty disks (match NBT data). When I came to the disk manipulator I found a disk with -448/64000 available space in it.
http://i.imgur.com/6KAb7aB.png
Version (Make sure you are on the latest version before reporting):
- Minecraft: 1.10.2
- Forge: 12.18.2.2112
- Refined Storage: 1.2-beta2
Does this issue occur on a server? [yes/no]
Yes
If a (crash)log is relevant for this issue, link it here:
No log
And it just created one with -192/64000.. Here's the NBT info:
http://i.imgur.com/F3QQeFm.png
I piped 40 disks with different contents and amounts total through the Disk Manipulator, and ended up with 29 normal empty disks (0/64000) and 11 disks with varying negative numbers.
Can you try with just shift clicking manually (without the pipes) and see if it works that way?
The disks go into the correct slot and start emptying out properly, it seems to be some form of overflow or such during the emptying process. Also, the first disk with the error was left within the Disk Manipulator since the NBT didn't match.
More testing on this issue:
I set up a small RS system with just a disk drive, a crafting grid and a controller to run the test. The disk drive reports -1216/64000 (that is also the disk info):
http://i.imgur.com/HLJYrJb.png
After adding 1 stack of cobblestone:
http://i.imgur.com/f0Al8xo.png
Wonder if the count went out of whack due to the other now fixed issue with it counting multiple imported items in a stack as one item. Just a shot in the dark. Wonder if it still does that with beta4.
I don't know, but I could set up my system to empty out again, see if I get
any corrupted drives.
Just a thought though, perhaps you could add a possibility for someone to
clear a disk - just like you can shift right click patterns. Maybe
something more. A disk format kind of thing? That way at least I can
recover the 8 or so corrupted ones I have, but it could also serve as a
quick way of getting rid of unwanted things.
On Thu, 27 Oct 2016 at 21:25, Michel Dusseault [email protected]
wrote:
Wonder if the count went out of whack due to the other now fixed issue
with it counting multiple imported items in a stack as one item. Just a
shot in the dark. Wonder if it still does that with beta4.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#520 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AArzBqGnKrZoMEo_QjWTkOKzBEk3Ht8Zks5q4PqXgaJpZM4KgQ4F
.
Is there a 'fsck' disk sanity check operation that could be part of either accessing the disk or when its inserted to the drive?
Great, now I'm thinking of a 'failure' mechanic of tiered disks and drives; cheap disks are fine but after a while items go missing and you can make better quality ones that are less prone to dropping items. Combine them into a Redundant Array of Item/Fluid Storage Disks for safety, but if your RAID goes bonk, you're boned.
same.. lol... we should make a addon which adds it. back to the issue. we should add a sanity check for if it is less than 0 then we forcibly change it to 0.
The cause of this issue is really #908