Refined Storage

Refined Storage

115M Downloads

An exporter pointing to an interface with water as a filter crashes the game

starforcraft opened this issue ยท 0 comments

commented

Describe the bug

Pointing an exporter at an interface crashes the game with a fluid filter (only on fabric)

How can we reproduce this bug or crash?

  1. Build a system
  2. Point an exporter at an interface
  3. Set the filter to water (or any other fluid)

What Minecraft version is this happening on?

Minecraft 1.21

What NeoForge or Fabric version is this happening on?

Fabric 0.100.4+1.21

What Refined Storage version is this happening on?

v2.0.0-milestone.4.4

Relevant log output

---- Minecraft Crash Report ----
// Who set us up the TNT?

Time: 2024-07-13 15:08:33
Description: Ticking block entity

java.lang.NullPointerException: Cannot invoke "net.fabricmc.fabric.impl.transfer.item.ItemVariantImpl.getCachedStack()" because "insertedVariant" is null
	at net.fabricmc.fabric.impl.transfer.item.InventorySlotWrapper.insert(InventorySlotWrapper.java:80)
	at net.fabricmc.fabric.impl.transfer.item.InventorySlotWrapper.insert(InventorySlotWrapper.java:43)
	at net.fabricmc.fabric.api.transfer.v1.storage.base.CombinedStorage.insert(CombinedStorage.java:61)
	at com.refinedmods.refinedstorage.platform.fabric.storage.FabricStorageInsertableStorage.doInsert(FabricStorageInsertableStorage.java:57)
	at com.refinedmods.refinedstorage.platform.fabric.storage.FabricStorageInsertableStorage.insert(FabricStorageInsertableStorage.java:52)
	at com.refinedmods.refinedstorage.api.storage.TransferHelper.transfer(TransferHelper.java:45)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.ExporterTransferStrategyImpl.tryTransfer(ExporterTransferStrategyImpl.java:52)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.ExporterTransferStrategyImpl.tryTransferExpanded(ExporterTransferStrategyImpl.java:44)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.ExporterTransferStrategyImpl.transfer(ExporterTransferStrategyImpl.java:37)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.CompositeExporterTransferStrategy.transfer(CompositeExporterTransferStrategy.java:20)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.ExporterNetworkNode$TaskImpl.run(ExporterNetworkNode.java:76)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.ExporterNetworkNode$TaskImpl.run(ExporterNetworkNode.java:64)
	at com.refinedmods.refinedstorage.api.network.impl.node.task.DefaultTaskExecutor.execute(DefaultTaskExecutor.java:12)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.ExporterNetworkNode.doWork(ExporterNetworkNode.java:44)
	at com.refinedmods.refinedstorage.platform.common.support.network.BaseNetworkNodeContainerBlockEntity.doWork(BaseNetworkNodeContainerBlockEntity.java:82)
	at com.refinedmods.refinedstorage.platform.common.support.network.AbstractUpgradeableNetworkNodeContainerBlockEntity.doWork(AbstractUpgradeableNetworkNodeContainerBlockEntity.java:56)
	at com.refinedmods.refinedstorage.platform.common.support.network.NetworkNodeBlockEntityTicker.tick(NetworkNodeBlockEntityTicker.java:36)
	at com.refinedmods.refinedstorage.platform.common.support.network.NetworkNodeBlockEntityTicker.tick(NetworkNodeBlockEntityTicker.java:15)
	at net.minecraft.world.level.chunk.LevelChunk$BoundTickingBlockEntity.tick(LevelChunk.java:683)
	at net.minecraft.world.level.chunk.LevelChunk$RebindableTickingBlockEntityWrapper.tick(LevelChunk.java:737)
	at net.minecraft.world.level.Level.tickBlockEntities(Level.java:488)
	at net.minecraft.server.level.ServerLevel.tick(ServerLevel.java:413)
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1021)
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:912)
	at net.minecraft.client.server.IntegratedServer.tickServer(IntegratedServer.java:114)
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:697)
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:281)
	at java.base/java.lang.Thread.run(Thread.java:1583)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Server thread
Stacktrace:
	at net.fabricmc.fabric.impl.transfer.item.InventorySlotWrapper.insert(InventorySlotWrapper.java:80)
	at net.fabricmc.fabric.impl.transfer.item.InventorySlotWrapper.insert(InventorySlotWrapper.java:43)
	at net.fabricmc.fabric.api.transfer.v1.storage.base.CombinedStorage.insert(CombinedStorage.java:61)
	at com.refinedmods.refinedstorage.platform.fabric.storage.FabricStorageInsertableStorage.doInsert(FabricStorageInsertableStorage.java:57)
	at com.refinedmods.refinedstorage.platform.fabric.storage.FabricStorageInsertableStorage.insert(FabricStorageInsertableStorage.java:52)
	at com.refinedmods.refinedstorage.api.storage.TransferHelper.transfer(TransferHelper.java:45)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.ExporterTransferStrategyImpl.tryTransfer(ExporterTransferStrategyImpl.java:52)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.ExporterTransferStrategyImpl.tryTransferExpanded(ExporterTransferStrategyImpl.java:44)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.ExporterTransferStrategyImpl.transfer(ExporterTransferStrategyImpl.java:37)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.CompositeExporterTransferStrategy.transfer(CompositeExporterTransferStrategy.java:20)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.ExporterNetworkNode$TaskImpl.run(ExporterNetworkNode.java:76)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.ExporterNetworkNode$TaskImpl.run(ExporterNetworkNode.java:64)
	at com.refinedmods.refinedstorage.api.network.impl.node.task.DefaultTaskExecutor.execute(DefaultTaskExecutor.java:12)
	at com.refinedmods.refinedstorage.api.network.impl.node.exporter.ExporterNetworkNode.doWork(ExporterNetworkNode.java:44)
	at com.refinedmods.refinedstorage.platform.common.support.network.BaseNetworkNodeContainerBlockEntity.doWork(BaseNetworkNodeContainerBlockEntity.java:82)
	at com.refinedmods.refinedstorage.platform.common.support.network.AbstractUpgradeableNetworkNodeContainerBlockEntity.doWork(AbstractUpgradeableNetworkNodeContainerBlockEntity.java:56)
	at com.refinedmods.refinedstorage.platform.common.support.network.NetworkNodeBlockEntityTicker.tick(NetworkNodeBlockEntityTicker.java:36)
	at com.refinedmods.refinedstorage.platform.common.support.network.NetworkNodeBlockEntityTicker.tick(NetworkNodeBlockEntityTicker.java:15)
	at net.minecraft.world.level.chunk.LevelChunk$BoundTickingBlockEntity.tick(LevelChunk.java:683)
	at net.minecraft.world.level.chunk.LevelChunk$RebindableTickingBlockEntityWrapper.tick(LevelChunk.java:737)
	at net.minecraft.world.level.Level.tickBlockEntities(Level.java:488)

-- Block entity being ticked --
Details:
	Name: refinedstorage:exporter // com.refinedmods.refinedstorage.platform.common.exporter.ExporterBlockEntity
	Block: Block{refinedstorage:exporter}[direction=east,down=false,east=false,north=false,south=false,up=false,waterlogged=false,west=true]
	Block location: World: (12,71,6), Section: (at 12,7,6 in 0,4,0; chunk contains blocks 0,-64,0 to 15,319,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511)
	Block: Block{refinedstorage:exporter}[direction=east,down=false,east=false,north=false,south=false,up=false,waterlogged=false,west=true]
	Block location: World: (12,71,6), Section: (at 12,7,6 in 0,4,0; chunk contains blocks 0,-64,0 to 15,319,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511)
Stacktrace:
	at net.minecraft.world.level.chunk.LevelChunk$BoundTickingBlockEntity.tick(LevelChunk.java:683)
	at net.minecraft.world.level.chunk.LevelChunk$RebindableTickingBlockEntityWrapper.tick(LevelChunk.java:737)
	at net.minecraft.world.level.Level.tickBlockEntities(Level.java:488)
	at net.minecraft.server.level.ServerLevel.tick(ServerLevel.java:413)
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1021)
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:912)
	at net.minecraft.client.server.IntegratedServer.tickServer(IntegratedServer.java:114)
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:697)
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:281)
	at java.base/java.lang.Thread.run(Thread.java:1583)

-- Affected level --
Details:
	All players: 1 total; [ServerPlayer['Player681'/106, l='ServerLevel[New World]', x=12.11, y=71.00, z=5.42]]
	Chunk stats: 2601
	Level dimension: minecraft:overworld
	Level spawn location: World: (0,70,0), Section: (at 0,6,0 in 0,4,0; chunk contains blocks 0,-64,0 to 15,319,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511)
	Level time: 3533 game time, 3533 day time
	Level name: New World
	Level game mode: Game mode: creative (ID 1). Hardcore: false. Commands: true
	Level weather: Rain time: 142583 (now: false), thunder time: 152178 (now: false)
	Known server brands: fabric
	Removed feature flags: 
	Level was modded: true
	Level storage version: 0x04ABD - Anvil
	Loaded entity count: 425
Stacktrace:
	at net.minecraft.server.level.ServerLevel.fillReportDetails(ServerLevel.java:1693)
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1024)
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:912)
	at net.minecraft.client.server.IntegratedServer.tickServer(IntegratedServer.java:114)
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:697)
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:281)
	at java.base/java.lang.Thread.run(Thread.java:1583)

-- System Details --
Details:
	Minecraft Version: 1.21
	Minecraft Version ID: 1.21
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 21.0.3, Eclipse Adoptium
	Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Eclipse Adoptium
	Memory: 753606368 bytes (718 MiB) / 2373976064 bytes (2264 MiB) up to 8514437120 bytes (8120 MiB)
	CPUs: 16
	Processor Vendor: GenuineIntel
	Processor Name: 13th Gen Intel(R) Core(TM) i5-13400F
	Identifier: Intel64 Family 6 Model 191 Stepping 2
	Microarchitecture: unknown
	Frequency (GHz): 2.50
	Number of physical packages: 1
	Number of physical CPUs: 10
	Number of logical CPUs: 16
	Graphics card #0 name: NVIDIA GeForce RTX 4060 Ti
	Graphics card #0 vendor: NVIDIA
	Graphics card #0 VRAM (MiB): 8188.00
	Graphics card #0 deviceId: VideoController1
	Graphics card #0 versionInfo: 32.0.15.5599
	Memory slot #0 capacity (MiB): 16384.00
	Memory slot #0 clockSpeed (GHz): 2.13
	Memory slot #0 type: DDR4
	Memory slot #1 capacity (MiB): 16384.00
	Memory slot #1 clockSpeed (GHz): 2.13
	Memory slot #1 type: DDR4
	Virtual memory max (MiB): 37342.12
	Virtual memory used (MiB): 23019.99
	Swap memory total (MiB): 4864.00
	Swap memory used (MiB): 401.27
	Space in storage for jna.tmpdir (MiB): <path not set>
	Space in storage for org.lwjgl.system.SharedLibraryExtractPath (MiB): <path not set>
	Space in storage for io.netty.native.workdir (MiB): <path not set>
	Space in storage for java.io.tmpdir (MiB): available: 1143593.63, total: 1907712.00
	Space in storage for workdir (MiB): available: 1143593.63, total: 1907712.00
	JVM Flags: 0 total; 
	Fabric Mods: 
		cloth-basic-math: cloth-basic-math 0.6.1
		cloth-config: Cloth Config v15 15.0.127
		fabric-api: Fabric API 0.100.4+1.21
		fabric-api-base: Fabric API Base 0.4.42+6573ed8cd1
		fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.67+b5597344d1
		fabric-biome-api-v1: Fabric Biome API (v1) 13.0.28+6fc22b99d1
		fabric-block-api-v1: Fabric Block API (v1) 1.0.22+0af3f5a7d1
		fabric-block-view-api-v2: Fabric BlockView API (v2) 1.0.10+6573ed8cd1
		fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.52+0af3f5a7d1
		fabric-client-tags-api-v1: Fabric Client Tags 1.1.15+6573ed8cd1
		fabric-command-api-v1: Fabric Command API (v1) 1.2.48+f71b366fd1
		fabric-command-api-v2: Fabric Command API (v2) 2.2.27+6a6dfa19d1
		fabric-commands-v0: Fabric Commands (v0) 0.2.65+df3654b3d1
		fabric-content-registries-v0: Fabric Content Registries (v0) 8.0.14+b5597344d1
		fabric-convention-tags-v1: Fabric Convention Tags 2.0.15+7f945d5bd1
		fabric-convention-tags-v2: Fabric Convention Tags (v2) 2.3.2+78017270d1
		fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.29+0af3f5a7d1
		fabric-data-attachment-api-v1: Fabric Data Attachment API (v1) 1.1.24+6a6dfa19d1
		fabric-data-generation-api-v1: Fabric Data Generation API (v1) 20.2.9+16c4ae25d1
		fabric-dimensions-v1: Fabric Dimensions API (v1) 4.0.0+6fc22b99d1
		fabric-entity-events-v1: Fabric Entity Events (v1) 1.6.12+6fc22b99d1
		fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.7.10+e633f883d1
		fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.52+6573ed8cd1
		fabric-gametest-api-v1: Fabric Game Test API (v1) 2.0.2+6fc22b99d1
		fabric-item-api-v1: Fabric Item API (v1) 11.0.0+afdfc921d1
		fabric-item-group-api-v1: Fabric Item Group API (v1) 4.1.2+78017270d1
		fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.47+0af3f5a7d1
		fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.45+df3654b3d1
		fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.3.11+8f3583aed1
		fabric-loot-api-v2: Fabric Loot API (v2) 3.0.11+6573ed8cd1
		fabric-message-api-v1: Fabric Message API (v1) 6.0.13+6573ed8cd1
		fabric-model-loading-api-v1: Fabric Model Loading API (v1) 2.0.0+fe474d6bd1
		fabric-networking-api-v1: Fabric Networking API (v1) 4.2.0+ab7edbacd1
		fabric-object-builder-api-v1: Fabric Object Builder API (v1) 15.1.12+d1321076d1
		fabric-particles-v1: Fabric Particles (v1) 4.0.2+6573ed8cd1
		fabric-recipe-api-v1: Fabric Recipe API (v1) 5.0.10+65089712d1
		fabric-registry-sync-v0: Fabric Registry Sync (v0) 5.0.23+78017270d1
		fabric-renderer-api-v1: Fabric Renderer API (v1) 3.3.0+0ae0b97dd1
		fabric-renderer-indigo: Fabric Renderer - Indigo 1.6.5+48fb1586d1
		fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.67+df3654b3d1
		fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.48+73761d2ed1
		fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.1.6+b5597344d1
		fabric-rendering-v0: Fabric Rendering (v0) 1.1.70+df3654b3d1
		fabric-rendering-v1: Fabric Rendering (v1) 5.0.4+5a8c785ed1
		fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 4.2.1+d153f344d1
		fabric-resource-loader-v0: Fabric Resource Loader (v0) 1.1.5+78017270d1
		fabric-screen-api-v1: Fabric Screen API (v1) 2.0.24+b5597344d1
		fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.3.80+b5597344d1
		fabric-sound-api-v1: Fabric Sound API (v1) 1.0.23+6573ed8cd1
		fabric-transfer-api-v1: Fabric Transfer API (v1) 5.1.15+3dccd343d1
		fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 6.0.12+6573ed8cd1
		fabricloader: Fabric Loader 0.15.11
		java: OpenJDK 64-Bit Server VM 21
		minecraft: Minecraft 1.21
		mixinextras: MixinExtras 0.3.5
		modmenu: Mod Menu 11.0.1
		refinedstorage: Refined Storage 0.0.0
		refinedstorage-core-api: Refined Storage Core API 0.0.0
		refinedstorage-grid-api: Refined Storage Grid API 0.0.0
		refinedstorage-network: Refined Storage Network 0.0.0
		refinedstorage-network-api: Refined Storage Network API 0.0.0
		refinedstorage-query-parser: Refined Storage Query Parser 0.0.0
		refinedstorage-resource-api: Refined Storage Resource API 0.0.0
		refinedstorage-storage-api: Refined Storage Storage API 0.0.0
		team_reborn_energy: Energy 4.1.0
	Server Running: true
	Player Count: 1 / 8; [ServerPlayer['Player681'/106, l='ServerLevel[New World]', x=12.11, y=71.00, z=5.42]]
	Active Data Packs: vanilla, fabric, fabric-convention-tags-v2, fabric-gametest-api-v1, refinedstorage
	Available Data Packs: bundle, fabric, fabric-convention-tags-v2, fabric-gametest-api-v1, refinedstorage, trade_rebalance, vanilla
	Enabled Feature Flags: minecraft:vanilla
	World Generation: Stable
	World Seed: -248157684631431741
	Type: Integrated Server (map_client.txt)
	Is Modded: Definitely; Client brand changed to 'fabric'; Server brand changed to 'fabric'
	Launched Version: Fabric