Refined Storage

Refined Storage

Mods
115M Downloads

Grid Update Causes Crash

Bradhosk1 opened this issue · 1 comments

commented

I'm having an issue where when using the grid or crafting grid and i attempt to search or browse through the stored items i get a crash rarely

Environment

Minecraft: 1.21.1
NeoForge: 21.1.125
Refined Storage: 2.0.0-milestone.4.14
Java: Java 21
Launcher: Prism Launcher

Additional Context
The error specifically occurs in GridViewImpl.updateBackingList() on line 177 where an Optional fails to return a value. I have multiple mods installed that may interact with inventory/storage systems which could be related to this issue.

How can we reproduce this bug or crash?

Steps to Reproduce

Open a Refined Storage grid interface
Normal grid usage causes the crash when updating the view very rare

What Minecraft version is this happening on?

Minecraft 1.21.1

What NeoForge or Fabric version is this happening on?

NeoForge: 21.1.125

What Refined Storage version is this happening on?

Refined Storage: 2.0.0-milestone.4.14

Relevant log output

[23:31:20] [Render thread/ERROR] [ne.ne.ne.ne.re.NetworkRegistry/]: Failed to process a synchronized task of the payload: refinedstorage:grid_update
java.util.concurrent.CompletionException: java.lang.RuntimeException
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315)
	...
Caused by: java.lang.RuntimeException
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.api.grid.view.GridViewImpl.updateBackingList(GridViewImpl.java:177)
	at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.api.grid.view.GridViewImpl.onChange(GridViewImpl.java:159)
	at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.grid.AbstractGridContainerMenu.onResourceUpdate(AbstractGridContainerMenu.java:180)
	at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.support.packet.s2c.GridUpdatePacket.handle(GridUpdatePacket.java:34)


All The Mods 10 - 2.38 crashed. The logs have been uploaded to `gnomebot.dev`:
### [latest.log head](<https://gnomebot.dev/paste/mclogs/yrAUcY6>) / [tail](<https://gnomebot.dev/paste/mclogs/6NNBCdH>) (~12MB & ~91k lines)   |   [debug.log head](<https://gnomebot.dev/paste/mclogs/evegdVJ>) / [tail](<https://gnomebot.dev/paste/mclogs/sLpcSSY>) (~88MB & ~302k lines)   |   [crash-2025-02-28_23.31.40-server.txt](<https://gnomebot.dev/paste/mclogs/S2lK8Zi>)   |   [PrismLauncher-0.log](<https://gnomebot.dev/paste/mclogs/wArafln>)   |   KubeJS: [client.log](<https://gnomebot.dev/paste/mclogs/IqyDzMo>) / [server.log](<https://gnomebot.dev/paste/mclogs/Umf56J4>) / [startup.log](<https://gnomebot.dev/paste/mclogs/POUb6QD>)   |   [crash_assistant_app.log](<https://gnomebot.dev/paste/mclogs/Y1FKzmg>)

### Mod list changes beyond the modpack:

Added mods:
�[2;32mrefinedstorage-curios-integration-0.3.0.jar�[0m
�[2;32mrefinedstorage-jei-integration-neoforge-0.7.0.jar�[0m
�[2;32mrefinedstorage-neoforge-2.0.0-milestone.4.14.jar�[0m
�[2;32mrefinedstorage-quartz-arsenal-neoforge-0.1.2.jar�[0m
commented

Looking at the code, you got an update packet for a removal that wasn't present in your list before. That shouldn't be able to happen (TCP packets happen in order?). But I'll make to code a bit more error prone regarding this.