Refined Storage

Refined Storage

115M Downloads

Trying to open any block in spectator mode results in network protocol error

starforcraft opened this issue ยท 2 comments

commented

Describe the bug

Title

How can we reproduce this bug or crash?

  1. Go into Spectator Mode
  2. Try to open any block from RS

What Minecraft version is this happening on?

Minecraft 1.21.1

What NeoForge or Fabric version is this happening on?

21.1.115

What Refined Storage version is this happening on?

4.14

Relevant log output

Description: Packet handling error

java.lang.NullPointerException: Cannot invoke "io.netty.buffer.ByteBuf.readByte()" because "buffer" is null
	at TRANSFORMER/[email protected]/net.minecraft.network.VarLong.read(VarLong.java:31) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.network.codec.ByteBufCodecs$7.decode(ByteBufCodecs.java:101) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.network.codec.ByteBufCodecs$7.decode(ByteBufCodecs.java:99) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.network.codec.StreamCodec$8.decode(StreamCodec.java:137) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.neoforge.ModInitializer$12.lambda$create$0(ModInitializer.java:446) ~[refinedstorage-neoforge-2.0.0-milestone.4.14.jar%23197!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.neoforged.neoforge.network.IContainerFactory.create(IContainerFactory.java:18) ~[neoforge-21.1.115.jar%23189!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.world.inventory.MenuType.create(MenuType.java:54) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.screens.MenuScreens$ScreenConstructor.fromPacket(MenuScreens.java:127) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.screens.MenuScreens.lambda$create$0(MenuScreens.java:44) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at java.base/java.util.Optional.ifPresent(Optional.java:178) ~[?:?] {}
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.screens.MenuScreens.create(MenuScreens.java:44) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.client.multiplayer.ClientPacketListener.handleOpenScreen(ClientPacketListener.java:1298) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.network.protocol.game.ClientboundOpenScreenPacket.handle(ClientboundOpenScreenPacket.java:42) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.network.protocol.game.ClientboundOpenScreenPacket.handle(ClientboundOpenScreenPacket.java:13) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:36) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:151) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:111) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.runTick(Minecraft.java:1161) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.run(Minecraft.java:813) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.client.main.Main.main(Main.java:230) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?] {}
	at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:136) ~[loader-4.0.35.jar%23139!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:124) ~[loader-4.0.35.jar%23139!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.NeoForgeClientUserdevLaunchHandler.runService(NeoForgeClientUserdevLaunchHandler.java:23) ~[loader-4.0.35.jar%23139!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.lambda$launchService$4(CommonLaunchHandler.java:118) ~[loader-4.0.35.jar%23139!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) [modlauncher-11.0.4.jar%23121!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-11.0.4.jar%23121!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-11.0.4.jar%23121!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:103) [modlauncher-11.0.4.jar%23121!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:74) [modlauncher-11.0.4.jar%23121!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-11.0.4.jar%23121!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-11.0.4.jar%23121!/:?] {}
	at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.run(BootstrapLauncher.java:210) [bootstraplauncher-2.0.2.jar:?] {}
	at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:69) [bootstraplauncher-2.0.2.jar:?] {}
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?] {}
	at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?] {}
	at net.neoforged.devlaunch.Main.main(Main.java:55) [DevLaunch-1.0.1.jar:?] {}


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
	at TRANSFORMER/[email protected]/net.minecraft.network.VarLong.read(VarLong.java:31) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.network.codec.ByteBufCodecs$7.decode(ByteBufCodecs.java:101) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.network.codec.ByteBufCodecs$7.decode(ByteBufCodecs.java:99) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.network.codec.StreamCodec$8.decode(StreamCodec.java:137) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.neoforge.ModInitializer$12.lambda$create$0(ModInitializer.java:446) ~[refinedstorage-neoforge-2.0.0-milestone.4.14.jar%23197!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.neoforged.neoforge.network.IContainerFactory.create(IContainerFactory.java:18) ~[neoforge-21.1.115.jar%23189!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.world.inventory.MenuType.create(MenuType.java:54) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.screens.MenuScreens$ScreenConstructor.fromPacket(MenuScreens.java:127) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.screens.MenuScreens.lambda$create$0(MenuScreens.java:44) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at java.base/java.util.Optional.ifPresent(Optional.java:178) ~[?:?] {}
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.screens.MenuScreens.create(MenuScreens.java:44) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
-- Incoming Packet --
Details:
	Type: clientbound/minecraft:open_screen
	Is Terminal: false
	Is Skippable: false
Stacktrace:
	at TRANSFORMER/[email protected]/net.minecraft.network.protocol.PacketUtils.fillCrashReport(PacketUtils.java:65) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.client.multiplayer.ClientCommonPacketListenerImpl.storeDisconnectionReport(ClientCommonPacketListenerImpl.java:130) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.client.multiplayer.ClientCommonPacketListenerImpl.onPacketError(ClientCommonPacketListenerImpl.java:114) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:42) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:151) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:111) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.runTick(Minecraft.java:1161) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.run(Minecraft.java:813) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.client.main.Main.main(Main.java:230) ~[neoforge-21.1.115.jar%23188!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?] {}
	at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:136) ~[loader-4.0.35.jar%23139!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:124) ~[loader-4.0.35.jar%23139!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.NeoForgeClientUserdevLaunchHandler.runService(NeoForgeClientUserdevLaunchHandler.java:23) ~[loader-4.0.35.jar%23139!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.lambda$launchService$4(CommonLaunchHandler.java:118) ~[loader-4.0.35.jar%23139!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) [modlauncher-11.0.4.jar%23121!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-11.0.4.jar%23121!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-11.0.4.jar%23121!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:103) [modlauncher-11.0.4.jar%23121!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:74) [modlauncher-11.0.4.jar%23121!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-11.0.4.jar%23121!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-11.0.4.jar%23121!/:?] {}
	at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.run(BootstrapLauncher.java:210) [bootstraplauncher-2.0.2.jar:?] {}
	at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:69) [bootstraplauncher-2.0.2.jar:?] {}
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?] {}
	at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?] {}
	at net.neoforged.devlaunch.Main.main(Main.java:55) [DevLaunch-1.0.1.jar:?] {}
commented

Looks like a NeoForge & Fabric at first sight.

commented

Nope, my bug