Refined Storage

Refined Storage

Mods
115M Downloads

Shared Inventory + External storage = Item flickering in grid

Demsli opened this issue ยท 2 comments

commented
2025-03-05.20-53-23.mp4

Describe the bug

When connecting an external storage to an ender chest from EnderStorage or Dimensional Chest from DimStorage - items start to flicker in the opened grid.

How can we reproduce this bug or crash?

  1. Place an ender chest from EnderStorage or Dimensional Chest from DimStorage and connect it to external storage
  2. Insert any item into the chest inventory
  3. Open grid
  4. See items flickering

What Minecraft version is this happening on?

Minecraft 1.21.1

What NeoForge or Fabric version is this happening on?

21.1.126

What Refined Storage version is this happening on?

refinedstorage-neoforge-2.0.0-milestone.4.14

Relevant log output

This is what's shown in debug.log:
[06mar.2025 00:40:34.188] [Server thread/DEBUG] [com.refinedmods.refinedstorage.common.storage.externalstorage.AbstractExternalStorageBlockEntity/]: Loading storage for external storage with direction north @ BlockPos{x=-9, y=-60, z=-3}
[06mar.2025 00:40:34.188] [Server thread/DEBUG] [com.refinedmods.refinedstorage.common.grid.AbstractGridContainerMenu/]: com.refinedmods.refinedstorage.common.grid.CraftingGridContainerMenu@3b8cc0e2 received a change of -64 for ItemResource[item=minecraft:jungle_log, components={}]
[06mar.2025 00:40:34.193] [Render thread/DEBUG] [com.refinedmods.refinedstorage.common.grid.AbstractGridContainerMenu/]: ItemResource[item=minecraft:jungle_log, components={}] got updated with -64
[06mar.2025 00:40:34.194] [Render thread/DEBUG] [com.refinedmods.refinedstorage.api.grid.view.GridViewImpl/]: ItemResource[item=minecraft:jungle_log, components={}] was already found in the view list
[06mar.2025 00:40:34.194] [Render thread/DEBUG] [com.refinedmods.refinedstorage.api.grid.view.GridViewImpl/]: Actually updating ItemResource[item=minecraft:jungle_log, components={}] resource in the view list
[06mar.2025 00:40:34.488] [Server thread/DEBUG] [com.refinedmods.refinedstorage.common.grid.AbstractGridContainerMenu/]: com.refinedmods.refinedstorage.common.grid.CraftingGridContainerMenu@3b8cc0e2 received a change of 64 for ItemResource[item=minecraft:jungle_log, components={}]
[06mar.2025 00:40:34.488] [Server thread/DEBUG] [com.refinedmods.refinedstorage.common.storage.externalstorage.AbstractExternalStorageBlockEntity/]: External storage @ BlockPos{x=-9, y=-60, z=-3} has changed!
commented

Yes, this is because the Ender Storage is causing a neighbor changed event. RS sees this and thinks the block has been replaced, and reloads the entire storage.

In RS 1, this causes the resources no longer being extractable from the Grid.

In RS 2, they probably get removed and re-added from the Grid, but you do have flickering.

commented

Related RS 1 issue: refinedmods/refinedstorage#2568