Refined Storage

Refined Storage

Mods
77M Downloads

Crash about crafting grid sorting

pupaxxo opened this issue ยท 10 comments

commented

Issue description:

Crash when crafting (manually) using the crafting grid

What happens:

Game crash

What you expected to happen:

Game not to crash

Version (Make sure you are on the latest version before reporting):

  • Minecraft: 1.10.2
  • Forge: 12.18.3.2202
  • Refined Storage: 1.2.16

Does this issue occur on a server? yes

If a (crash)log is relevant for this issue, link it here:

java.lang.IllegalArgumentException: Comparison method violates its general contract!
	at java.util.TimSort.mergeHi(TimSort.java:899)
	at java.util.TimSort.mergeAt(TimSort.java:516)
	at java.util.TimSort.mergeCollapse(TimSort.java:441)
	at java.util.TimSort.sort(TimSort.java:245)
	at java.util.Arrays.sort(Arrays.java:1512)
	at java.util.ArrayList.sort(ArrayList.java:1454)
	at java.util.Collections.sort(Collections.java:175)
	at com.raoulvdberge.refinedstorage.gui.grid.GuiGrid.sortItems(GuiGrid.java:175)
	at com.raoulvdberge.refinedstorage.gui.grid.GuiGrid.update(GuiGrid.java:203)
	at com.raoulvdberge.refinedstorage.gui.GuiBase.func_73876_c(GuiBase.java:92)
commented

What is your grid configuration? How are the items sorted?

commented
commented

This crash is very rare, it only happens when a itemcount is being sorted WHILE the itemcount is changing. I'll look into fixing this.

commented

Just encountered the exact same issue with 1.2.18 (identical stack-trace to above. Can pastebin the rest of crashlog if useful)

I have most of my grids set to sort by qty, but the possibly odd part here is I didnt' have a grid open at teh time. I was just looking at my normal player inventory when crash happened.

commented

Post the stacktrace please

commented

I think I'll add a dirty hack since this concurrency problem occurs rarely anyway

commented

I've had this happen to me several times recently on the FTB Skyfactory Challenges Map (almost every time I run the map). Stack trace: https://gist.github.com/M4thG33k/fb4e5d004371673b14e0c2e55c1b3bbe

I'm not sure if it's coincidence or not, but it almost always happens some time after I place the mortar and pestle from Botania into storage.

commented

Should be fixed in modern RS versions. If this is still an issue, let me know.

commented

Having the same issue quite regularly due to having a large automated gathering system.
Full crash report: https://paste.ee/p/ajSXI