Refined Storage

Refined Storage

77M Downloads

TileCable should avoid being ticked

sfPlayer1 opened this issue ยท 5 comments

commented

Besides decoration, cables and pipes are typically the most commonly used tile entities by a large margin. Since every ticking TE comes with a substantial cost for every tick and during chunk loads/unloads, TileCable shouldn't implement ITickable if at all possible.

commented

It doesn't do anything when ticking, is the cost that high?

commented

Per my most recent observation on FC's SF3 instance roughly 35% of the total tick time go towards mere te quantity/management overhead, excluding any actual work in te.update(). RS cables are ~17% of the ticking te quantity.

That suggests quite heavily that having thousands of TEs tick is a bad idea, especially if they don't serve any purpose. I've also had quite some success with this kind of optimization before, e.g. some fake light blocks for long range lights killed servers despite not doing anything of significance in updateEntity().

commented

I'll look into removing them being a TE, then.

commented

Ignore if nonsense, but xnet cables are not TE, maybe you could check it out for inspiration.

commented

This issue has been fixed, no inspiration needed :P